Skip to content

Commit

Permalink
HADOOP-17594. DistCp: Expose the JobId for applications executing thr…
Browse files Browse the repository at this point in the history
…ough run method (#2786). Contributed by Ayush Saxena.

Signed-off-by: Mingliang Liu <liuml07@apache.org>
Signed-off-by: Steve Loughran <stevel@apache.org>
  • Loading branch information
ayushtkn committed Mar 19, 2021
1 parent 8ec256d commit 162923e
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
Expand Up @@ -214,6 +214,8 @@ public Job createAndSubmitJob() throws Exception {
String jobID = job.getJobID().toString();
job.getConfiguration().set(DistCpConstants.CONF_LABEL_DISTCP_JOB_ID,
jobID);
// Set the jobId for the applications running through run method.
getConf().set(DistCpConstants.CONF_LABEL_DISTCP_JOB_ID, jobID);
LOG.info("DistCp job-id: " + jobID);

return job;
Expand Down
Expand Up @@ -19,6 +19,7 @@
package org.apache.hadoop.tools.contract;

import static org.apache.hadoop.fs.contract.ContractTestUtils.*;
import static org.apache.hadoop.tools.DistCpConstants.CONF_LABEL_DISTCP_JOB_ID;

import java.io.IOException;
import java.util.Collections;
Expand All @@ -42,6 +43,7 @@
import org.apache.hadoop.tools.DistCpConstants;
import org.apache.hadoop.tools.DistCpOptions;
import org.apache.hadoop.tools.mapred.CopyMapper;
import org.apache.hadoop.tools.util.DistCpTestUtils;

import org.junit.Before;
import org.junit.Rule;
Expand Down Expand Up @@ -464,6 +466,17 @@ public void testLargeFilesFromRemote() throws Exception {
largeFiles(remoteFS, remoteDir, localFS, localDir);
}

@Test
public void testSetJobId() throws Exception {
describe("check jobId is set in the conf");
remoteFS.create(new Path(remoteDir, "file1")).close();
DistCpTestUtils
.assertRunDistCp(DistCpConstants.SUCCESS, remoteDir.toString(),
localDir.toString(), null, conf);
assertNotNull("DistCp job id isn't set",
conf.get(CONF_LABEL_DISTCP_JOB_ID));
}

/**
* Executes a DistCp using a file system sub-tree with multiple nesting
* levels.
Expand Down

0 comments on commit 162923e

Please sign in to comment.