HDDS-1723. Create new OzoneManagerLock class. #1006

bharatviswa504 · 2019-06-22T00:10:55Z

Thank You @anuengineer for offline discussion and help during the code of using Short and bit manipulation, instead of BitSet.

If someone is interested in how the code looks like with BitSet, refer below link.
https://github.com/bharatviswa504/hadoop-1/blob/bhcode-anucode/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock1.java

hadoop-yetus · 2019-06-22T01:41:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	28	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	65	Maven dependency ordering for branch
+1	mvninstall	564	trunk passed
+1	compile	251	trunk passed
+1	checkstyle	62	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	806	branch has no errors when building and testing our client artifacts.
+1	javadoc	162	trunk passed
0	spotbugs	306	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	493	trunk passed
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
+1	mvninstall	437	the patch passed
+1	compile	266	the patch passed
+1	javac	266	the patch passed
-0	checkstyle	31	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	663	patch has no errors when building and testing our client artifacts.
+1	javadoc	161	the patch passed
-1	findbugs	318	hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1	unit	238	hadoop-hdds in the patch passed.
-1	unit	138	hadoop-ozone in the patch failed.
+1	asflicense	45	The patch does not generate ASF License warnings.
		5168

Reason	Tests
FindBugs	module:hadoop-ozone
	org.apache.hadoop.ozone.om.lock.OzoneManagerLock.lambda$new$0() invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead At OzoneManagerLock.java:constructor; use Short.valueOf(short) instead At OzoneManagerLock.java:[line 62]
Failed junit tests	hadoop.ozone.om.ratis.TestOzoneManagerDoubleBufferWithOMResponse

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/2/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux bf1587e66275 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `371452e`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/2/artifact/out/new-findbugs-hadoop-ozone.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/2/testReport/
Max. process+thread count	492 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-22T01:58:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1430	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	86	Maven dependency ordering for branch
+1	mvninstall	564	trunk passed
+1	compile	249	trunk passed
+1	checkstyle	63	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	877	branch has no errors when building and testing our client artifacts.
+1	javadoc	151	trunk passed
0	spotbugs	221	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	84	hadoop-ozone in trunk failed.
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
-1	mvninstall	14	hadoop-hdds in the patch failed.
-1	mvninstall	26	hadoop-ozone in the patch failed.
-1	compile	32	hadoop-ozone in the patch failed.
-1	javac	32	hadoop-ozone in the patch failed.
+1	checkstyle	63	the patch passed
+1	mvnsite	0	the patch passed
-1	whitespace	0	The patch has 65 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1	whitespace	1	The patch 600 line(s) with tabs.
+1	shadedclient	673	patch has no errors when building and testing our client artifacts.
-1	javadoc	86	hadoop-ozone generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-1	findbugs	36	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	194	hadoop-hdds in the patch failed.
-1	unit	39	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		5469

Reason	Tests
Failed junit tests	hadoop.ozone.container.ozoneimpl.TestOzoneContainer

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux b7be4208fdc5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `371452e`
Default Java	1.8.0_212
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/patch-compile-hadoop-ozone.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/whitespace-eol.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/whitespace-tabs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/testReport/
Max. process+thread count	444 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-22T02:02:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	70	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	69	Maven dependency ordering for branch
+1	mvninstall	484	trunk passed
+1	compile	247	trunk passed
+1	checkstyle	67	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	891	branch has no errors when building and testing our client artifacts.
+1	javadoc	157	trunk passed
0	spotbugs	330	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	642	trunk passed
		_ Patch Compile Tests _
0	mvndep	31	Maven dependency ordering for patch
+1	mvninstall	446	the patch passed
+1	compile	263	the patch passed
+1	javac	263	the patch passed
-0	checkstyle	40	hadoop-ozone: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	739	patch has no errors when building and testing our client artifacts.
+1	javadoc	164	the patch passed
-1	findbugs	314	hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1	unit	264	hadoop-hdds in the patch passed.
-1	unit	1305	hadoop-ozone in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		6637

Reason	Tests
FindBugs	module:hadoop-ozone
	org.apache.hadoop.ozone.om.lock.OzoneManagerLock.lambda$new$0() invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead At OzoneManagerLock.java:constructor; use Short.valueOf(short) instead At OzoneManagerLock.java:[line 62]
Failed junit tests	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 80bd016d9872 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `371452e`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/artifact/out/new-findbugs-hadoop-ozone.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/testReport/
Max. process+thread count	5017 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-22T02:07:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	30	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	75	Maven dependency ordering for branch
+1	mvninstall	472	trunk passed
+1	compile	240	trunk passed
+1	checkstyle	65	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	818	branch has no errors when building and testing our client artifacts.
+1	javadoc	154	trunk passed
0	spotbugs	321	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	519	trunk passed
		_ Patch Compile Tests _
0	mvndep	33	Maven dependency ordering for patch
+1	mvninstall	442	the patch passed
+1	compile	257	the patch passed
+1	javac	257	the patch passed
+1	checkstyle	75	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	647	patch has no errors when building and testing our client artifacts.
+1	javadoc	161	the patch passed
+1	findbugs	517	the patch passed
		_ Other Tests _
-1	unit	157	hadoop-hdds in the patch failed.
-1	unit	1000	hadoop-ozone in the patch failed.
+1	asflicense	53	The patch does not generate ASF License warnings.
		5892

Reason	Tests
Failed junit tests	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/4/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 2d1d889c932f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `371452e`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/4/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/4/testReport/
Max. process+thread count	5269 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-22T02:16:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	23	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	65	Maven dependency ordering for branch
+1	mvninstall	495	trunk passed
+1	compile	258	trunk passed
+1	checkstyle	68	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	899	branch has no errors when building and testing our client artifacts.
+1	javadoc	156	trunk passed
0	spotbugs	330	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	539	trunk passed
		_ Patch Compile Tests _
0	mvndep	46	Maven dependency ordering for patch
+1	mvninstall	447	the patch passed
+1	compile	262	the patch passed
+1	javac	262	the patch passed
+1	checkstyle	73	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	722	patch has no errors when building and testing our client artifacts.
+1	javadoc	152	the patch passed
+1	findbugs	527	the patch passed
		_ Other Tests _
+1	unit	248	hadoop-hdds in the patch passed.
-1	unit	1155	hadoop-ozone in the patch failed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		6335

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/5/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 31a32ca36b95 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `371452e`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/5/testReport/
Max. process+thread count	4699 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-24T18:33:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	31	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	65	Maven dependency ordering for branch
+1	mvninstall	487	trunk passed
+1	compile	262	trunk passed
+1	checkstyle	72	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	865	branch has no errors when building and testing our client artifacts.
+1	javadoc	157	trunk passed
0	spotbugs	310	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	498	trunk passed
		_ Patch Compile Tests _
0	mvndep	34	Maven dependency ordering for patch
+1	mvninstall	443	the patch passed
+1	compile	267	the patch passed
+1	javac	267	the patch passed
+1	checkstyle	80	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	685	patch has no errors when building and testing our client artifacts.
+1	javadoc	162	the patch passed
+1	findbugs	519	the patch passed
		_ Other Tests _
+1	unit	235	hadoop-hdds in the patch passed.
-1	unit	1307	hadoop-ozone in the patch failed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		6393

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.hdds.scm.pipeline.TestNode2PipelineMap
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/6/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 96075b2d0310 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `b220ec6`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/6/testReport/
Max. process+thread count	5325 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-24T18:40:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	23	Maven dependency ordering for branch
+1	mvninstall	514	trunk passed
+1	compile	259	trunk passed
+1	checkstyle	68	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	913	branch has no errors when building and testing our client artifacts.
+1	javadoc	159	trunk passed
0	spotbugs	320	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	517	trunk passed
		_ Patch Compile Tests _
0	mvndep	31	Maven dependency ordering for patch
+1	mvninstall	454	the patch passed
+1	compile	261	the patch passed
+1	javac	261	the patch passed
+1	checkstyle	74	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	730	patch has no errors when building and testing our client artifacts.
+1	javadoc	156	the patch passed
+1	findbugs	535	the patch passed
		_ Other Tests _
+1	unit	285	hadoop-hdds in the patch passed.
-1	unit	1452	hadoop-ozone in the patch failed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		6679

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestSCMPipelineManager
	hadoop.ozone.client.rpc.TestBCSID

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/7/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 0e143af120e5 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `b220ec6`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/7/testReport/
Max. process+thread count	4781 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

anuengineer

Overall, it looks excellent. Some very minor comments inline. I am +1 after these comments are looked at.

hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java

bharatviswa504 · 2019-06-24T21:54:44Z

Thank You @anuengineer for the review.
I have addressed the review comments.

hadoop-yetus · 2019-06-24T23:17:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	32	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	21	Maven dependency ordering for branch
+1	mvninstall	472	trunk passed
+1	compile	256	trunk passed
+1	checkstyle	67	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	799	branch has no errors when building and testing our client artifacts.
+1	javadoc	148	trunk passed
0	spotbugs	305	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	493	trunk passed
		_ Patch Compile Tests _
0	mvndep	29	Maven dependency ordering for patch
+1	mvninstall	417	the patch passed
+1	compile	242	the patch passed
+1	javac	242	the patch passed
+1	checkstyle	62	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	623	patch has no errors when building and testing our client artifacts.
+1	javadoc	141	the patch passed
+1	findbugs	501	the patch passed
		_ Other Tests _
+1	unit	229	hadoop-hdds in the patch passed.
-1	unit	1170	hadoop-ozone in the patch failed.
+1	asflicense	36	The patch does not generate ASF License warnings.
		5859

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.TestStorageContainerManager
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestFailureHandlingByClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/8/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux afba5320c9cd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `129576f`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/8/testReport/
Max. process+thread count	5072 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-24T23:30:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	29	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	20	Maven dependency ordering for branch
+1	mvninstall	449	trunk passed
+1	compile	241	trunk passed
+1	checkstyle	63	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	784	branch has no errors when building and testing our client artifacts.
+1	javadoc	141	trunk passed
0	spotbugs	312	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	497	trunk passed
		_ Patch Compile Tests _
0	mvndep	28	Maven dependency ordering for patch
+1	mvninstall	412	the patch passed
+1	compile	238	the patch passed
+1	javac	238	the patch passed
-0	checkstyle	36	hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	611	patch has no errors when building and testing our client artifacts.
+1	javadoc	159	the patch passed
+1	findbugs	531	the patch passed
		_ Other Tests _
+1	unit	233	hadoop-hdds in the patch passed.
-1	unit	1058	hadoop-ozone in the patch failed.
+1	asflicense	49	The patch does not generate ASF License warnings.
		5743

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/9/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux b89d15c3ec24 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `129576f`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/9/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/9/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/9/testReport/
Max. process+thread count	4563 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/9/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-25T00:20:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	893	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	64	Maven dependency ordering for branch
+1	mvninstall	475	trunk passed
+1	compile	243	trunk passed
+1	checkstyle	67	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	892	branch has no errors when building and testing our client artifacts.
+1	javadoc	154	trunk passed
0	spotbugs	306	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	491	trunk passed
		_ Patch Compile Tests _
0	mvndep	29	Maven dependency ordering for patch
+1	mvninstall	421	the patch passed
+1	compile	247	the patch passed
+1	javac	247	the patch passed
+1	checkstyle	72	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedclient	686	patch has no errors when building and testing our client artifacts.
+1	javadoc	149	the patch passed
+1	findbugs	505	the patch passed
		_ Other Tests _
+1	unit	262	hadoop-hdds in the patch passed.
-1	unit	1710	hadoop-ozone in the patch failed.
+1	asflicense	40	The patch does not generate ASF License warnings.
		7548

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/10/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 95409dcc34c1 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `129576f`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/10/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/10/testReport/
Max. process+thread count	5389 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/10/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

bharatviswa504 · 2019-06-25T02:14:33Z

Test failures are not related to this patch.

anuengineer

+1, Thank you for getting this done. I have some minor comments, nothing important. You might want to see if @arp7 or @nandakumar131 wants to comment and wait for a day before commtting.

hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java

bharatviswa504 · 2019-06-25T04:44:02Z

Thank You @anuengineer for the review.
I have fixed the review comments.

hadoop-yetus · 2019-06-25T06:38:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	30	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	62	Maven dependency ordering for branch
+1	mvninstall	473	trunk passed
+1	compile	243	trunk passed
+1	checkstyle	69	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	851	branch has no errors when building and testing our client artifacts.
+1	javadoc	156	trunk passed
0	spotbugs	307	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	503	trunk passed
		_ Patch Compile Tests _
0	mvndep	35	Maven dependency ordering for patch
+1	mvninstall	431	the patch passed
+1	compile	261	the patch passed
+1	javac	261	the patch passed
+1	checkstyle	79	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	678	patch has no errors when building and testing our client artifacts.
+1	javadoc	159	the patch passed
+1	findbugs	515	the patch passed
		_ Other Tests _
+1	unit	250	hadoop-hdds in the patch passed.
-1	unit	1567	hadoop-ozone in the patch failed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		6573

Reason	Tests
Failed junit tests	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/13/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 28d53a6a73cc 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `041e7a7`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/13/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/13/testReport/
Max. process+thread count	5335 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/13/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-25T06:47:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	28	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	64	Maven dependency ordering for branch
+1	mvninstall	476	trunk passed
+1	compile	238	trunk passed
+1	checkstyle	60	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	782	branch has no errors when building and testing our client artifacts.
+1	javadoc	154	trunk passed
0	spotbugs	305	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	501	trunk passed
		_ Patch Compile Tests _
0	mvndep	32	Maven dependency ordering for patch
+1	mvninstall	446	the patch passed
+1	compile	257	the patch passed
+1	javac	257	the patch passed
+1	checkstyle	71	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	645	patch has no errors when building and testing our client artifacts.
+1	javadoc	146	the patch passed
+1	findbugs	550	the patch passed
		_ Other Tests _
-1	unit	245	hadoop-hdds in the patch failed.
-1	unit	2321	hadoop-ozone in the patch failed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		7203

Reason	Tests
Failed junit tests	hadoop.hdds.scm.block.TestBlockManager
	hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
	hadoop.hdds.scm.pipeline.TestSCMPipelineManager
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.om.TestScmSafeMode
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/12/artifact/out/Dockerfile
GITHUB PR	#1006
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 401be25ec7c2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `041e7a7`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/12/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/12/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/12/testReport/
Max. process+thread count	4007 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/12/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

anuengineer

+1, I will commit this patch now. Thanks for the contribution.

* HDDS-1723. Create new OzoneManagerLock class. * add logs * fix exception message * add license * fix findbug * throw exception when acquiring 2nd lock failed. * fix review comments * fix missed review comment * fix checkstyle * fix review comments

… of metadata resources (apache#1006) * Implement MetadataResourceLoader to encapsulate loading of metadata resources. * Rename MetadataResourceLoader to MetadataResourceManager * Rename to MetadataResourceUtil and remove unused methods. * Remove any API changes that refer to future PRs.

* HDDS-1723. Create new OzoneManagerLock class. * add logs * fix exception message * add license * fix findbug * throw exception when acquiring 2nd lock failed. * fix review comments * fix missed review comment * fix checkstyle * fix review comments

bharatviswa504 requested review from arp7 and anuengineer June 22, 2019 00:10

bharatviswa504 self-assigned this Jun 22, 2019

bharatviswa504 added the ozone label Jun 22, 2019

bharatviswa504 force-pushed the HDDS-1723 branch from 87009fb to c61cf0d Compare June 24, 2019 16:47

anuengineer reviewed Jun 24, 2019

View reviewed changes

bharatviswa504 added 7 commits June 24, 2019 14:17

HDDS-1723. Create new OzoneManagerLock class.

787fcc3

add logs

6ae2108

fix exception message

9e3d823

add license

daef5cd

fix findbug

2595084

throw exception when acquiring 2nd lock failed.

7bff810

fix review comments

3ed81da

bharatviswa504 force-pushed the HDDS-1723 branch from c61cf0d to 3ed81da Compare June 24, 2019 21:39

fix missed review comment

a5d2490

fix checkstyle

d75851d

anuengineer approved these changes Jun 25, 2019

View reviewed changes

bharatviswa504 force-pushed the HDDS-1723 branch from a5b146e to 497b151 Compare June 25, 2019 04:45

fix review comments

919dc4c

bharatviswa504 force-pushed the HDDS-1723 branch from 497b151 to 919dc4c Compare June 25, 2019 04:47

anuengineer approved these changes Jun 25, 2019

View reviewed changes

anuengineer merged commit 049bb42 into apache:trunk Jun 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDDS-1723. Create new OzoneManagerLock class. #1006

HDDS-1723. Create new OzoneManagerLock class. #1006

bharatviswa504 commented Jun 22, 2019 •

edited

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 24, 2019

hadoop-yetus commented Jun 24, 2019

anuengineer left a comment

bharatviswa504 commented Jun 24, 2019

hadoop-yetus commented Jun 24, 2019

hadoop-yetus commented Jun 24, 2019

hadoop-yetus commented Jun 25, 2019

bharatviswa504 commented Jun 25, 2019

anuengineer left a comment

bharatviswa504 commented Jun 25, 2019

hadoop-yetus commented Jun 25, 2019

hadoop-yetus commented Jun 25, 2019

anuengineer left a comment

HDDS-1723. Create new OzoneManagerLock class. #1006

HDDS-1723. Create new OzoneManagerLock class. #1006

Conversation

bharatviswa504 commented Jun 22, 2019 • edited

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 22, 2019

hadoop-yetus commented Jun 24, 2019

hadoop-yetus commented Jun 24, 2019

anuengineer left a comment

Choose a reason for hiding this comment

bharatviswa504 commented Jun 24, 2019

hadoop-yetus commented Jun 24, 2019

hadoop-yetus commented Jun 24, 2019

hadoop-yetus commented Jun 25, 2019

bharatviswa504 commented Jun 25, 2019

anuengineer left a comment

Choose a reason for hiding this comment

bharatviswa504 commented Jun 25, 2019

hadoop-yetus commented Jun 25, 2019

hadoop-yetus commented Jun 25, 2019

anuengineer left a comment

Choose a reason for hiding this comment

bharatviswa504 commented Jun 22, 2019 •

edited