HDDS-1603. Handle Ratis Append Failure in Container State Machine. Contributed by Supratim Deka #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
…ntributed by Supratim Deka
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
mukul1987
requested changes
Jul 8, 2019
| @@ -545,18 +545,28 @@ private void handlePipelineFailure(RaftGroupId groupId, | |||
| + roleInfoProto.getRole()); | |||
| } | |||
|
|
|||
| triggerPipelineClose(groupId, msg, | |||
There was a problem hiding this comment.
Lets have 2 Reasons, a) candidate failed, b) leader failed
| try { | ||
| pipelineManager.getPipeline(openPipeline.getId()); | ||
| } catch (PipelineNotFoundException e) { | ||
| Assert.assertTrue("pipeline should exist", false); |
There was a problem hiding this comment.
In Junit, the test will exit if an uncaught exception is thrown, so this might not be needed.
arp7
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
+1, will hold off submitting since @mukul1987 has couple of questions.
|
+1, from me as well. Lets create followup jira for the review comments. |
|
💔 -1 overall
This message was automatically generated. |
bshashikant
pushed a commit
to bshashikant/hadoop
that referenced
this pull request
Jul 10, 2019
…ntributed by Supratim Deka (apache#1019)
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
* Adding parameterized tests for legacy-offset file * Adding test for checking precedence between offset files
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…ntributed by Supratim Deka (apache#1019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDDS-1603
The scope of this jira is to build on https://issues.apache.org/jira/browse/RATIS-573
and define the handling for Ratis log append failure in Ozone Container State Machine.
Ratis-573 is not available in trunk. So this patch starts with an entry point in XceiverServerRatis which will be hooked up to notifyLogFailed() callback defined in StateMachine as part of RATIS-573.
Notify Ratis volume unhealthy to the Datanode is not implemented in this patch