Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-1616. ManagedChannel references are being leaked in while removing RaftGroup. Contributed by Mukul Kumar Singh. #1039

Merged
merged 1 commit into from Jul 2, 2019

Conversation

mukul1987
Copy link
Contributor

RaftClient references are being leaked while removing pipeline.

…ng RaftGroup. Contributed by Mukul Kumar Singh.
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 31 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 545 trunk passed
+1 compile 238 trunk passed
+1 checkstyle 65 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 812 branch has no errors when building and testing our client artifacts.
+1 javadoc 148 trunk passed
0 spotbugs 295 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 476 trunk passed
_ Patch Compile Tests _
+1 mvninstall 420 the patch passed
+1 compile 241 the patch passed
+1 javac 241 the patch passed
+1 checkstyle 63 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 613 patch has no errors when building and testing our client artifacts.
+1 javadoc 143 the patch passed
+1 findbugs 520 the patch passed
_ Other Tests _
-1 unit 243 hadoop-hdds in the patch failed.
-1 unit 1042 hadoop-ozone in the patch failed.
+1 asflicense 37 The patch does not generate ASF License warnings.
5795
Reason Tests
Failed junit tests hadoop.hdds.scm.safemode.TestSCMSafeModeManager
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestWatchForCommit
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1039/1/artifact/out/Dockerfile
GITHUB PR #1039
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 20470fe8e42e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d203045
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1039/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1039/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1039/1/testReport/
Max. process+thread count 5206 (vs. ulimit of 5500)
modules C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1039/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, pending CI.
Thank You @mukul1987 for the contribution.

Labeled it as Ozone, to trigger CI run.

@mukul1987
Copy link
Contributor Author

/retest

@mukul1987 mukul1987 self-assigned this Jul 2, 2019
@bharatviswa504 bharatviswa504 merged commit 8b0d1ad into apache:trunk Jul 2, 2019
@bharatviswa504
Copy link
Contributor

Test failures are not related to this patch.
Thank You @mukul1987 for the contribution.
I have committed this to trunk.

asfgit pushed a commit that referenced this pull request Jul 2, 2019
…ng RaftGroup. Contributed by Mukul Kumar Singh. (#1039)

(cherry picked from commit 8b0d1ad)
bshashikant pushed a commit to bshashikant/hadoop that referenced this pull request Jul 10, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
* SAMZA-2197: [Scala cleanup] Convert TaskConfig to Java
* moving constants to TaskConfigJava
* renaming TaskConfigJava to TaskConfig and modifying visibility on some constants
* update private method access in TestJobCoordinator
* clean up unused methods in TaskConfig
* update javadocs, use Java Optional, move some defaults to TaskConfig
* post-merge fixes
* test and import fixes
* fix javadoc, clean up if-else check, fix format
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants