New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-1800. Result of author check is inverted #1092
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/label ozone |
@elek please review |
💔 -1 overall
This message was automatically generated. |
elek
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thanks the fix @adoroszlai
But I would prefer to commit it under a separated issue number. I created https://issues.apache.org/jira/browse/HDDS-1800 to use.
adoroszlai
changed the title
HDDS-1735. Result of author check is inverted
HDDS-1800. Result of author check is inverted
Jul 15, 2019
elek
pushed a commit
that referenced
this pull request
Jul 15, 2019
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
… to ms instead of ns (apache#1092) * Making container-startup-time a gauge. It is currently a timer. * Using long-gauge for container-startup-time * Converting startup time to millis
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix:
Eg. https://ci.anzix.net/job/ozone-nightly/173/consoleText says that:
but no actual
@author
tags were found:How was this patch tested?