HDDS-1803. shellcheck.sh does not work on Mac

[adoroszlai]

What changes were proposed in this pull request?

• Filter for file permission on Mac.
• Merge two separate find calls to avoid overwriting output (and eliminate code duplication).

https://issues.apache.org/jira/browse/HDDS-1803

How was this patch tested?

$ hadoop-ozone/dev-support/checks/shellcheck.sh | wc
     133     600    6065

$ wc target/shell-problems.txt
     133     600    6065 target/shell-problems.txt

[adoroszlai]

/label ozone

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	71	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	shelldocs	0	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	492	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	843	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1	mvninstall	444	the patch passed
+1	mvnsite	0	the patch passed
+1	shellcheck	1	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	739	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1	unit	115	hadoop-hdds in the patch passed.
+1	unit	193	hadoop-ozone in the patch passed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		3141

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1102/1/artifact/out/Dockerfile
GITHUB PR	#1102
Optional Tests	dupname asflicense mvnsite unit shellcheck shelldocs
uname	Linux 773ae44f6140 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / f77d54c
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1102/1/testReport/
Max. process+thread count	307 (vs. ulimit of 5500)
modules	C: hadoop-ozone U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1102/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	74	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	shelldocs	0	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	516	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	888	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1	mvninstall	497	the patch passed
+1	mvnsite	0	the patch passed
+1	shellcheck	0	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	772	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1	unit	107	hadoop-hdds in the patch passed.
+1	unit	185	hadoop-ozone in the patch passed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		3285

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1102/2/artifact/out/Dockerfile
GITHUB PR	#1102
Optional Tests	dupname asflicense mvnsite unit shellcheck shelldocs
uname	Linux 2c17343b881a 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / c58e11b
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1102/2/testReport/
Max. process+thread count	306 (vs. ulimit of 5500)
modules	C: hadoop-ozone U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1102/2/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
0	shelldocs	1	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	551	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	777	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1	mvninstall	471	the patch passed
+1	mvnsite	0	the patch passed
+1	shellcheck	0	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	673	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1	unit	98	hadoop-hdds in the patch passed.
+1	unit	170	hadoop-ozone in the patch passed.
+1	asflicense	40	The patch does not generate ASF License warnings.
		2989

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1102/3/artifact/out/Dockerfile
GITHUB PR	#1102
Optional Tests	dupname asflicense mvnsite unit shellcheck shelldocs
uname	Linux 054075b12d03 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 4e66cb9
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1102/3/testReport/
Max. process+thread count	412 (vs. ulimit of 5500)
modules	C: hadoop-ozone U: hadoop-ozone
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1102/3/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[anuengineer]

Thank you for the patch. I have committed this to trunk and ozone-0.4.1