HDDS-1816: ContainerStateMachine should limit number of pending apply transactions #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
| int maxPendingApplyTransactions = conf.getInt( | ||
| ScmConfigKeys.DFS_CONTAINER_RATIS_STATEMACHINE_MAX_PENDING_APPLY_TRANSACTIONS, | ||
| ScmConfigKeys.DFS_CONTAINER_RATIS_STATEMACHINE_MAX_PENDING_APPLY_TRANSACTIONS_DEFAULT); | ||
| applyTransactionSemaphore = new Semaphore(maxPendingApplyTransactions); |
There was a problem hiding this comment.
Question: Here do we need fair setting, to follow the order?
There was a problem hiding this comment.
@bharatviswa504 Thanks for reviewing the changes! We do not need a fair setting as in Ratis StateMachineUpdater the call to applyTransaction is serialized.
|
Thanks @lokeshj1703 for working on this. As discussed offline, let's make the default value of the limit equal to snapshot interval in terms of log transactions as in any case, during restart snapshotIndex will determine how many entries from the log will be pending to be applied. |
|
@bshashikant Thanks for reviewing the PR! I have pushed commit addressing the comment. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
… transactions. Adds a config, uses snapshot threshold default value.
|
Latest commit brings back the config for maximum number of pending apply transactions, uses snapshot threshold default value as default value for the config. |
|
💔 -1 overall
This message was automatically generated. |
|
The patch looks good to me . +1 . |
|
Checkstyle seems to be related: https://issues.apache.org/jira/browse/HDDS-1878 |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…removed (apache#1150) In the previous PR: https://github.com/apache/samza/pull/1010/files config with null/empty values will be filter out when reading the coordinator stream, this will cause some problems when the user expects an empty string to be a value config.
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
… transactions. Adds a config, uses snapshot threshold default value. (apache#1150)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContainerStateMachine should limit number of pending apply transactions in order to avoid excessive heap usage by the pending transactions.