Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in conftest.py #1285

Closed
wants to merge 1 commit into from
Closed

Conversation

cclauss
Copy link

@cclauss cclauss commented Aug 12, 2019

Old style exceptions are syntax errors on Python 3 while new style exceptions work as expected on both Python 2 and Python 3.

Old style exceptions are syntax errors on Python 3 while new style exceptions work as expected on both Python 2 and Python 3.
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 50 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 627 trunk passed
-1 pylint 1 Error running pylint. Please check pylint stderr files.
+1 shadedclient 766 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 mvninstall 555 the patch passed
-1 pylint 1 Error running pylint. Please check pylint stderr files.
+1 pylint 2 There were no new pylint issues.
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedclient 624 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 unit 86 hadoop-hdds in the patch passed.
+1 unit 266 hadoop-ozone in the patch passed.
+1 asflicense 31 The patch does not generate ASF License warnings.
3161
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/1/artifact/out/Dockerfile
GITHUB PR #1285
Optional Tests dupname asflicense unit pylint
uname Linux d81dc661675a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 9b8359b
pylint https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/1/artifact/out/branch-pylint-stderr.txt
pylint https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/1/artifact/out/patch-pylint-stderr.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/1/testReport/
Max. process+thread count 447 (vs. ulimit of 5500)
modules C: hadoop-ozone/fault-injection-test/network-tests U: hadoop-ozone/fault-injection-test/network-tests
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/1/console
versions git=2.7.4 maven=3.3.9 pylint=1.9.2
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@cclauss
Copy link
Author

cclauss commented Aug 16, 2019

flake8 finds syntax errors while avoiding the false positives that pylint is so famous for:
https://lukeplant.me.uk/blog/posts/pylint-false-positives

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 574 trunk passed
-1 pylint 1 Error running pylint. Please check pylint stderr files.
+1 shadedclient 748 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 mvninstall 582 the patch passed
-1 pylint 1 Error running pylint. Please check pylint stderr files.
+1 pylint 2 There were no new pylint issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 663 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 unit 92 hadoop-hdds in the patch passed.
+1 unit 291 hadoop-ozone in the patch passed.
+1 asflicense 49 The patch does not generate ASF License warnings.
3197
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/2/artifact/out/Dockerfile
GITHUB PR #1285
Optional Tests dupname asflicense unit pylint
uname Linux 12d6d453fca0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6244502
pylint https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/2/artifact/out/branch-pylint-stderr.txt
pylint https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/2/artifact/out/patch-pylint-stderr.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/2/testReport/
Max. process+thread count 412 (vs. ulimit of 5500)
modules C: hadoop-ozone/fault-injection-test/network-tests U: hadoop-ozone/fault-injection-test/network-tests
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/2/console
versions git=2.7.4 maven=3.3.9 pylint=1.9.2
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 49 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 642 trunk passed
-1 pylint 1 Error running pylint. Please check pylint stderr files.
+1 shadedclient 786 branch has no errors when building and testing our client artifacts.
-0 patch 840 Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 mvninstall 593 the patch passed
-1 pylint 1 Error running pylint. Please check pylint stderr files.
+1 pylint 1 There were no new pylint issues.
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedclient 657 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 unit 94 hadoop-hdds in the patch passed.
+1 unit 287 hadoop-ozone in the patch passed.
+1 asflicense 36 The patch does not generate ASF License warnings.
3295
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/3/artifact/out/Dockerfile
Optional Tests dupname asflicense unit pylint
uname Linux 76355a9f9a16 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ee7c261
pylint https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/3/artifact/out/branch-pylint-stderr.txt
pylint https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/3/artifact/out/patch-pylint-stderr.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/3/testReport/
Max. process+thread count 447 (vs. ulimit of 5500)
modules C: hadoop-ozone/fault-injection-test/network-tests U: hadoop-ozone/fault-injection-test/network-tests
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/3/console
versions git=2.7.4 maven=3.3.9 pylint=1.9.2
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 119 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 707 trunk passed
-1 pylint 6 Error running pylint. Please check pylint stderr files.
+1 shadedclient 984 branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 mvninstall 659 the patch passed
-1 pylint 7 Error running pylint. Please check pylint stderr files.
+1 pylint 7 There were no new pylint issues.
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 812 patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 unit 107 hadoop-hdds in the patch passed.
+1 unit 301 hadoop-ozone in the patch passed.
+1 asflicense 36 The patch does not generate ASF License warnings.
3934
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/4/artifact/out/Dockerfile
GITHUB PR #1285
Optional Tests dupname asflicense unit pylint
uname Linux 7643fa5e5345 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3329257
pylint https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/4/artifact/out/branch-pylint-stderr.txt
pylint https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/4/artifact/out/patch-pylint-stderr.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/4/testReport/
Max. process+thread count 306 (vs. ulimit of 5500)
modules C: hadoop-ozone/fault-injection-test/network-tests U: hadoop-ozone/fault-injection-test/network-tests
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1285/4/console
versions git=2.7.4 maven=3.3.9 pylint=1.9.2
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@cclauss
Copy link
Author

cclauss commented Aug 27, 2019

IT IS EASIER TO HAVE AN AUTOMATON IGNORE THE SYNTAX ERRORS THAN TO FIX THEM.

@cclauss cclauss closed this Aug 27, 2019
@cclauss cclauss deleted the patch-1 branch August 27, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants