HDDS-2142. OM metrics mismatch (abort multipart request)

[adoroszlai]

What changes were proposed in this pull request?

• Fix wrong call to increment AbortMultipartUploadFails
• Add missing call to increment AbortMultipartUploads

https://issues.apache.org/jira/browse/HDDS-2142

How was this patch tested?

Ran ozones3 acceptance test, verified OM metrics page.

[adoroszlai]

/label ozone

[arp7]

+1

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	160	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
-1	mvninstall	33	hadoop-ozone in trunk failed.
-1	compile	23	hadoop-ozone in trunk failed.
-0	checkstyle	38	The patch fails to run checkstyle in hadoop-ozone
+1	mvnsite	0	trunk passed
+1	shadedclient	1041	branch has no errors when building and testing our client artifacts.
-1	javadoc	90	hadoop-ozone in trunk failed.
0	spotbugs	182	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	30	hadoop-ozone in trunk failed.
		_ Patch Compile Tests _
-1	mvninstall	35	hadoop-ozone in the patch failed.
-1	compile	26	hadoop-ozone in the patch failed.
-1	javac	26	hadoop-ozone in the patch failed.
-0	checkstyle	39	The patch fails to run checkstyle in hadoop-ozone
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	808	patch has no errors when building and testing our client artifacts.
-1	javadoc	97	hadoop-ozone in the patch failed.
-1	findbugs	26	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	344	hadoop-hdds in the patch failed.
-1	unit	31	hadoop-ozone in the patch failed.
+1	asflicense	37	The patch does not generate ASF License warnings.
		3879

Reason	Tests
Failed junit tests	hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware

Subsystem	Report/Notes
Docker	Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/Dockerfile
GITHUB PR	#1461
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ec2052e77e5a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / c474e24
Default Java	1.8.0_222
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/branch-compile-hadoop-ozone.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1461/out/maven-branch-checkstyle-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/patch-compile-hadoop-ozone.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1461/out/maven-patch-checkstyle-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/testReport/
Max. process+thread count	468 (vs. ulimit of 5500)
modules	C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1461/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[bharatviswa504]

+1

[bharatviswa504]

Thank You @adoroszlai for the contribution and @arp7 for the review.

[adoroszlai]

Thanks @arp7 for reviewing the fix and @bharatviswa504 for reviewing and merging it.