Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Abandoned] HADOOP-16612 Track Azure Blob File System client-perceived latency #1569

Closed
wants to merge 67 commits into from

Conversation

jeeteshm
Copy link

@jeeteshm jeeteshm commented Oct 1, 2019

Add instrumentation code to measure the ADLS Gen 2 API performance
Add a feature switch to optionally enable this feature
Add unit tests for correctness and performance

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 229 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1602 trunk passed
+1 compile 40 trunk passed
+1 checkstyle 32 trunk passed
+1 mvnsite 42 trunk passed
+1 shadedclient 1057 branch has no errors when building and testing our client artifacts.
+1 javadoc 31 trunk passed
0 spotbugs 67 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 65 trunk passed
_ Patch Compile Tests _
+1 mvninstall 39 the patch passed
+1 compile 40 the patch passed
+1 javac 40 the patch passed
-0 checkstyle 27 hadoop-tools/hadoop-azure: The patch generated 71 new + 5 unchanged - 0 fixed = 76 total (was 5)
+1 mvnsite 45 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 1032 patch has no errors when building and testing our client artifacts.
+1 javadoc 30 the patch passed
+1 findbugs 70 the patch passed
_ Other Tests _
+1 unit 87 hadoop-azure in the patch passed.
+1 asflicense 32 The patch does not generate ASF License warnings.
4619
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1569/1/artifact/out/Dockerfile
GITHUB PR #1569
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 6c880c1b063c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d947ded
Default Java 1.8.0_222
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1569/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1569/1/testReport/
Max. process+thread count 332 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1569/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

snvijaya and others added 28 commits October 1, 2019 17:38
…plyTransaction fails with closed container exception(apache#1552).
Signed-off-by: Anu Engineer <aengineer@apache.org>
…text on NameNode. Contributed by Chen Liang.
…ments in BUILDING.txt (apache#1558)

* Removed protobuf 3.7.1 from Dockerfile
Signed-off-by: Anu Engineer <aengineer@apache.org>
Signed-off-by: Anu Engineer <aengineer@apache.org>
adoroszlai and others added 22 commits October 4, 2019 17:37
Contributed by Steve Loughran.

This addresses two scale issues which has surfaced in large scale benchmarks
of the S3A Committers.

* Thread pools are not cleaned up.
  This now happens, with tests.

* OOM on job commit for jobs with many thousands of tasks,
  each generating tens of (very large) files.

Instead of loading all pending commits into memory as a single list, the list
of files to load is the sole list which is passed around; .pendingset files are
loaded and processed in isolation -and reloaded if necessary for any
abort/rollback operation.

The parallel commit/abort/revert operations now work at the .pendingset level,
rather than that of individual pending commit files. The existing parallelized
Tasks API is still used to commit those files, but with a null thread pool, so
as to serialize the operations.

Change-Id: I5c8240cd31800eaa83d112358770ca0eb2bca797
… Contributed by Prabhu Joseph"

This reverts commit 4510970.
Contributed by Steve Loughran.

Change-Id: Ife730b80057ddd43e919438cb5b2abbda990e636
…ion in assert statements

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Contributed by Bilahari T H.

This also addresses HADOOP-16498: AzureADAuthenticator cannot authenticate
in China.

Change-Id: I2441dd48b50b59b912b0242f7f5a4418cf94a87c
… cell fall in to AlignedStripe. Contributed by Surendra Singh Lilhore.
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 12 #1569 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #1569
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1569/2/console
versions git=2.17.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@jeeteshm jeeteshm closed this Oct 7, 2019
@jeeteshm
Copy link
Author

jeeteshm commented Oct 7, 2019

Raising a new PR because this one shows changes that don't belong to me.

@jeeteshm jeeteshm reopened this Oct 7, 2019
@jeeteshm jeeteshm closed this Oct 7, 2019
@virajith
Copy link
Contributor

virajith commented Oct 9, 2019

@jeeteshm -- can you clean up this PR to include only your changes?

@jeeteshm jeeteshm changed the title HADOOP-16612 Track Azure Blob File System client-perceived latency [Abandoned] HADOOP-16612 Track Azure Blob File System client-perceived latency Nov 5, 2019
@jeeteshm
Copy link
Author

jeeteshm commented Nov 5, 2019

Duplicate of #1611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet