HADOOP-16767 Handle non-IO exceptions in reopen()

[spoganshev]

Catch Exception instead of IOException in closeStream() to handle exceptions such as SdkClientException properly.

Jira Issue: https://issues.apache.org/jira/browse/HADOOP-16767

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 30s	trunk passed
+1 💚	compile	0m 31s	trunk passed
+1 💚	checkstyle	0m 22s	trunk passed
+1 💚	mvnsite	0m 35s	trunk passed
+1 💚	shadedclient	14m 37s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 24s	trunk passed
+0 🆗	spotbugs	0m 58s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 57s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	checkstyle	0m 18s	the patch passed
+1 💚	mvnsite	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 40s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 22s	the patch passed
+1 💚	findbugs	1m 1s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 19s	hadoop-aws in the patch passed.
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		60m 3s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1766/1/artifact/out/Dockerfile
GITHUB PR	#1766
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f713ddae6c35 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 2408066
Default Java	1.8.0_222
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1766/1/testReport/
Max. process+thread count	421 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1766/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[steveloughran]

makes sense, patch LGTM and I don't see how you'd easily write a test for it.

one little bit of homework: were did you run the hadoop-aws tests against?
https://hadoop.apache.org/docs/current/hadoop-aws/tools/hadoop-aws/testing.html#Policy_for_submitting_patches_which_affect_the_hadoop-aws_module.

sorry, but even for something trivial we have that due diligence check to stop anything getting in which causes a break.

[steveloughran]

Still expecting that declaration of which s3 endpoint you ran the mvn verify tests for hadoop-aws. we don't have time to run everyone elses PRs through the test suite as well as our own, and we have to push back to the authors. sorry

[steveloughran]

well, its a minor patch so I'll D/L and test myself, -Dparallel-tests -DtestsThreadCount=8 -Ds3guard -Ddynamo

So +1, merging in.

[cwensel]

@steveloughran any chance this will be backported to 2.10.x?