Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-16827. TestHarFileSystem.testInheritedMethodsImplemented broken. #1817

Merged
merged 1 commit into from Jan 24, 2020

Conversation

steveloughran
Copy link
Contributor

@steveloughran steveloughran commented Jan 24, 2020

This is a regression caused by HADOOP-16759.

The test TestHarFileSystem uses introspection to verify that HarFileSystem
Does not implement methods to which there is a suitable implementation in
the base FileSystem class. Because of the way it checks this, refactoring
(protected) FileSystem methods in an IDE do not automatically change
the probes in TestHarFileSystem.

The changes in HADOOP-16759 did exactly that, and somehow managed
to get through the build/test process without this being noticed.

This patch fixes that failure.

Caused by and fixed by Steve Loughran.

This is a regression caused by HADOOP-16759.

The test TestHarFileSystem uses introspection to verify that HarFileSystem
Does not implement methods to which there is a suitable implementation in
the base FileSystem class. Because of the way it checks this, refactoring
(protected) FileSystem methods in an IDE do not automatically change
the probes in TestHarFileSystem.

The changes in HADOOP-16759 did exactly that, and somehow managed
to get through the build/test process without this being noticed.

This patch fixes that failure.

Caused by and fixed by Steve Loughran.

Change-Id: If60d9c97058242871c02ad1addd424478f84f446
@steveloughran
Copy link
Contributor Author

caused by #1761

@liuml07 once Yetus is happy, could you review this?

@steveloughran steveloughran added bug failed yetus rejected, some other test failure. Means: not ready for use test test code changes and removed failed yetus rejected, some other test failure. Means: not ready for use labels Jan 24, 2020
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 20m 53s trunk passed
+1 💚 compile 17m 28s trunk passed
+1 💚 checkstyle 0m 46s trunk passed
+1 💚 mvnsite 1m 19s trunk passed
+1 💚 shadedclient 15m 42s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 23s trunk passed
+0 🆗 spotbugs 2m 5s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 2s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 48s the patch passed
+1 💚 compile 16m 48s the patch passed
+1 💚 javac 16m 48s the patch passed
-0 ⚠️ checkstyle 0m 45s hadoop-common-project/hadoop-common: The patch generated 1 new + 132 unchanged - 0 fixed = 133 total (was 132)
+1 💚 mvnsite 1m 25s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 28s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 38s the patch passed
+1 💚 findbugs 2m 42s the patch passed
_ Other Tests _
+1 💚 unit 10m 39s hadoop-common in the patch passed.
+1 💚 asflicense 0m 57s The patch does not generate ASF License warnings.
113m 16s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1817/1/artifact/out/Dockerfile
GITHUB PR #1817
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 2dbdec592a48 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 8390547
Default Java 1.8.0_232
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1817/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1817/1/testReport/
Max. process+thread count 1344 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1817/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@liuml07 liuml07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@liuml07 liuml07 merged commit 839e607 into apache:trunk Jan 24, 2020
@steveloughran steveloughran deleted the s3/HADOOP-16827-TestHar branch January 31, 2020 13:02
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
…n. (apache#1817)

This is a regression caused by HADOOP-16759.

The test TestHarFileSystem uses introspection to verify that HarFileSystem
Does not implement methods to which there is a suitable implementation in
the base FileSystem class. Because of the way it checks this, refactoring
(protected) FileSystem methods in an IDE do not automatically change
the probes in TestHarFileSystem.

The changes in HADOOP-16759 did exactly that, and somehow managed
to get through the build/test process without this being noticed.

This patch fixes that failure.

Caused by and fixed by Steve Loughran.

Change-Id: If60d9c97058242871c02ad1addd424478f84f446

Signed-off-by: Mingliang Liu <liuml07@apache.org>
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…n. (apache#1817)

This is a regression caused by HADOOP-16759.

The test TestHarFileSystem uses introspection to verify that HarFileSystem
Does not implement methods to which there is a suitable implementation in
the base FileSystem class. Because of the way it checks this, refactoring
(protected) FileSystem methods in an IDE do not automatically change
the probes in TestHarFileSystem.

The changes in HADOOP-16759 did exactly that, and somehow managed
to get through the build/test process without this being noticed.

This patch fixes that failure.

Caused by and fixed by Steve Loughran.

Change-Id: If60d9c97058242871c02ad1addd424478f84f446

Signed-off-by: Mingliang Liu <liuml07@apache.org>
(cherry picked from commit 839e607)
Change-Id: Ifee0b516065ed6aefa9a69c361185051b59b9606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug test test code changes
Projects
None yet
3 participants