New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-16827. TestHarFileSystem.testInheritedMethodsImplemented broken. #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression caused by HADOOP-16759. The test TestHarFileSystem uses introspection to verify that HarFileSystem Does not implement methods to which there is a suitable implementation in the base FileSystem class. Because of the way it checks this, refactoring (protected) FileSystem methods in an IDE do not automatically change the probes in TestHarFileSystem. The changes in HADOOP-16759 did exactly that, and somehow managed to get through the build/test process without this being noticed. This patch fixes that failure. Caused by and fixed by Steve Loughran. Change-Id: If60d9c97058242871c02ad1addd424478f84f446
steveloughran
added
bug
failed
yetus rejected, some other test failure. Means: not ready for use
test
test code changes
and removed
failed
yetus rejected, some other test failure. Means: not ready for use
labels
Jan 24, 2020
🎊 +1 overall
This message was automatically generated. |
liuml07
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
…n. (apache#1817) This is a regression caused by HADOOP-16759. The test TestHarFileSystem uses introspection to verify that HarFileSystem Does not implement methods to which there is a suitable implementation in the base FileSystem class. Because of the way it checks this, refactoring (protected) FileSystem methods in an IDE do not automatically change the probes in TestHarFileSystem. The changes in HADOOP-16759 did exactly that, and somehow managed to get through the build/test process without this being noticed. This patch fixes that failure. Caused by and fixed by Steve Loughran. Change-Id: If60d9c97058242871c02ad1addd424478f84f446 Signed-off-by: Mingliang Liu <liuml07@apache.org>
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…n. (apache#1817) This is a regression caused by HADOOP-16759. The test TestHarFileSystem uses introspection to verify that HarFileSystem Does not implement methods to which there is a suitable implementation in the base FileSystem class. Because of the way it checks this, refactoring (protected) FileSystem methods in an IDE do not automatically change the probes in TestHarFileSystem. The changes in HADOOP-16759 did exactly that, and somehow managed to get through the build/test process without this being noticed. This patch fixes that failure. Caused by and fixed by Steve Loughran. Change-Id: If60d9c97058242871c02ad1addd424478f84f446 Signed-off-by: Mingliang Liu <liuml07@apache.org> (cherry picked from commit 839e607) Change-Id: Ifee0b516065ed6aefa9a69c361185051b59b9606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression caused by HADOOP-16759.
The test TestHarFileSystem uses introspection to verify that HarFileSystem
Does not implement methods to which there is a suitable implementation in
the base FileSystem class. Because of the way it checks this, refactoring
(protected) FileSystem methods in an IDE do not automatically change
the probes in TestHarFileSystem.
The changes in HADOOP-16759 did exactly that, and somehow managed
to get through the build/test process without this being noticed.
This patch fixes that failure.
Caused by and fixed by Steve Loughran.