Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-16832 Update S3Guard testing doc. #1822

Merged

Conversation

mukund-thakur
Copy link
Contributor

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@steveloughran
Copy link
Contributor

You get those options set when you build with -Ds3guard -Ddynamo ; you shouldn't need to set them in the code. As once you do that, you can't turn them off.

@mukund-thakur
Copy link
Contributor Author

@steveloughran Yes i can use these option while running the tests using command line. But I was trying to run using Intellij idea and i had to set these params in auth-keys.xml.

@bgaborg
Copy link

bgaborg commented Jan 29, 2020

Please add this that you should set this just locally If you want to run tests in your IDE and don't want to play with parameters passed in the run configuration.
Local configuration is stored in auth-keys.xml. The changes to that file won't be committed, so it's safe to store local config there.

@mukund-thakur mukund-thakur force-pushed the HADOOP-16832-testing-doc-update branch 2 times, most recently from a9260b2 to 50a6585 Compare January 29, 2020 11:50
@bgaborg
Copy link

bgaborg commented Jan 29, 2020

@steveloughran what do you think about adding this to the doc? It may help people who are starting to contribute set things up more easily.

@steveloughran
Copy link
Contributor

It needs a sentence at the beginning:

How to set test options in your hadoop configuration rather than on the maven command line.

And at the end

warning although easier for IDE debugging setups, once you do this, you cannot change configurations on the mvn command line, such as testing without s3guard.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 25m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 19m 37s trunk passed
+1 💚 mvnsite 0m 40s trunk passed
+1 💚 shadedclient 32m 41s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 33s the patch passed
+1 💚 mvnsite 0m 32s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
74m 59s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1822/3/artifact/out/Dockerfile
GITHUB PR #1822
Optional Tests dupname asflicense mvnsite markdownlint
uname Linux 1185ad913813 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1e3a0b0
Max. process+thread count 412 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1822/3/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apache apache deleted a comment from hadoop-yetus Feb 5, 2020
@apache apache deleted a comment from hadoop-yetus Feb 5, 2020
Copy link

@bgaborg bgaborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 committing

@bgaborg bgaborg merged commit 146ca0f into apache:trunk Feb 6, 2020
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants