Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17001. The suffix name of the unified compression #1972

Closed
wants to merge 8 commits into from

Conversation

20100507
Copy link

JIRA: https://issues.apache.org/jira/browse/HADOOP-17001

The suffix name of the unified compression class,I think the suffix name in the compression class should be extracted into a constant class, which is helpful for developers to understand the structure of the compression class as a whole.

HADOOP-17001. The suffix name of the unified compression class
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 22m 1s trunk passed
-1 ❌ compile 17m 51s root in trunk failed.
+1 💚 checkstyle 0m 45s trunk passed
+1 💚 mvnsite 1m 24s trunk passed
+1 💚 shadedclient 17m 48s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 56s trunk passed
+0 🆗 spotbugs 2m 12s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 10s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 51s the patch passed
-1 ❌ compile 17m 41s root in the patch failed.
-1 ❌ javac 17m 41s root in the patch failed.
-0 ⚠️ checkstyle 0m 44s hadoop-common-project/hadoop-common: The patch generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)
+1 💚 mvnsite 1m 21s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 29s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 54s the patch passed
+1 💚 findbugs 2m 16s the patch passed
_ Other Tests _
+1 💚 unit 9m 39s hadoop-common in the patch passed.
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
114m 47s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1972/1/artifact/out/Dockerfile
GITHUB PR #1972
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e3b8c5f3e0df 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3d69383
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1972/1/artifact/out/branch-compile-root.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-1972/1/artifact/out/patch-compile-root.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-1972/1/artifact/out/patch-compile-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1972/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1972/1/testReport/
Max. process+thread count 3233 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1972/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@20100507
Copy link
Author

@jojochuang @liuml07 please review ,thank you ~

@jojochuang
Copy link
Contributor

There are compilation errors but don't look related.

@20100507 20100507 closed this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants