New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-17001. The suffix name of the unified compression #1972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HADOOP-17001. The suffix name of the unified compression class
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
HADOOP-17001. The suffix name of the unified compression
💔 -1 overall
This message was automatically generated. |
@jojochuang @liuml07 please review ,thank you ~ |
There are compilation errors but don't look related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HADOOP-17001
The suffix name of the unified compression class,I think the suffix name in the compression class should be extracted into a constant class, which is helpful for developers to understand the structure of the compression class as a whole.