Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17056. shelldoc fails in hadoop-common. #2045

Merged
merged 1 commit into from Jun 3, 2020

Conversation

aajisaka
Copy link
Member

@aajisaka aajisaka commented Jun 2, 2020

JIRA: https://issues.apache.org/jira/browse/HADOOP-17056

Skip GPG verification in the docker build image.

@hadoop-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/hadoop-multibranch/job/PR-2045/1/console in case of problems.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 1m 16s Maven dependency ordering for branch
+1 💚 shadedclient 16m 21s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for patch
+1 💚 hadolint 0m 5s There were no new hadolint issues.
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 50s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
37m 48s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2045/1/artifact/out/Dockerfile
GITHUB PR #2045
Optional Tests dupname asflicense shellcheck shelldocs hadolint
uname Linux 23cbe5ee7213 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 9fe4c37
Max. process+thread count 314 (vs. ulimit of 5500)
modules C: U:
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2045/1/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6 hadolint=1.11.1-0-g0e692dd
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@iwasakims
Copy link
Member

Is this message in cosole output relevant?

17:33:05  WARNING: shellcheck needs UTF-8 locale support. Forcing C.UTF-8.
17:33:05  executable '/testptch/hadoop/dev-support/bin/shelldocs' for 'shelldocs' does not exist.

@aajisaka
Copy link
Member Author

aajisaka commented Jun 3, 2020

Thank @iwasakims for your comment.

I think this output is not related to the patch. The warning has been there since at least May.
Ref:

We should fix it in a separate jira.

@aajisaka
Copy link
Member Author

aajisaka commented Jun 3, 2020

Filed https://issues.apache.org/jira/browse/HADOOP-17062 for tracking the issue.

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aajisaka. +1.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aajisaka aajisaka merged commit 9c290c0 into apache:trunk Jun 3, 2020
@aajisaka aajisaka deleted the HADOOP-17056-2 branch June 3, 2020 09:01
@aajisaka
Copy link
Member Author

aajisaka commented Jun 3, 2020

Thank you @iwasakims and @ayushtkn for your review.

aajisaka added a commit that referenced this pull request Jun 3, 2020
In the docker build image, skip GPG verification when downloading
Yetus tarball via yetus-wrapper.

(cherry picked from commit 9c290c0)
@aajisaka aajisaka restored the HADOOP-17056-2 branch June 3, 2020 09:05
@aajisaka
Copy link
Member Author

aajisaka commented Jun 3, 2020

I found a typo after committing this.

aajisaka added a commit that referenced this pull request Jun 4, 2020
In the docker build image, skip GPG verification when downloading
Yetus tarball via yetus-wrapper.

(cherry picked from commit 9c290c0)

 Conflicts:
	dev-support/docker/Dockerfile
	dev-support/docker/Dockerfile_aarch64
aajisaka added a commit that referenced this pull request Jun 4, 2020
In the docker build image, skip GPG verification when downloading
Yetus tarball via yetus-wrapper.

(cherry picked from commit 9c290c0)

 Conflicts:
	dev-support/docker/Dockerfile
	dev-support/docker/Dockerfile_aarch64

(cherry picked from commit aa19a2a)
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
In the docker build image, skip GPG verification when downloading
Yetus tarball via yetus-wrapper.

Change-Id: I6d1e80de81fb48e61f9c869dc1adaf425e19257d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants