Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-15476 Make AsyncStream executor private #2151

Merged
merged 2 commits into from
Jul 19, 2020

Conversation

surnaik
Copy link
Contributor

@surnaik surnaik commented Jul 18, 2020

The executor_ member of the AsyncStream class is public, but there is a getter get_executor() that returns this executor_ member. This member should be private.

@surnaik surnaik changed the title HDFS-15476: Make AsyncStream executor private HDFS-15476 Make AsyncStream executor private Jul 18, 2020
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 24m 8s trunk passed
+1 💚 compile 2m 13s trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 compile 2m 6s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 mvnsite 0m 20s trunk passed
+1 💚 shadedclient 44m 44s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 15s the patch passed
-1 ❌ compile 1m 28s hadoop-hdfs-native-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ cc 1m 28s hadoop-hdfs-native-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ golang 1m 28s hadoop-hdfs-native-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ javac 1m 28s hadoop-hdfs-native-client in the patch failed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.
-1 ❌ compile 1m 31s hadoop-hdfs-native-client in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.
-1 ❌ cc 1m 31s hadoop-hdfs-native-client in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.
-1 ❌ golang 1m 31s hadoop-hdfs-native-client in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.
-1 ❌ javac 1m 31s hadoop-hdfs-native-client in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.
+1 💚 mvnsite 0m 14s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 1m 58s hadoop-hdfs-native-client in the patch failed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
71m 28s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/Dockerfile
GITHUB PR #2151
Optional Tests dupname asflicense compile cc mvnsite javac unit golang
uname Linux f0eb833aec8f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 9965516
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
cc https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
golang https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
cc https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
golang https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-native-client.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/testReport/
Max. process+thread count 334 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 14s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 25m 25s trunk passed
+1 💚 compile 2m 49s trunk passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 compile 2m 36s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 mvnsite 0m 22s trunk passed
+1 💚 shadedclient 49m 48s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 17s the patch passed
+1 💚 compile 2m 26s the patch passed with JDK Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04
+1 💚 cc 2m 26s the patch passed
+1 💚 golang 2m 26s the patch passed
+1 💚 javac 2m 26s the patch passed
+1 💚 compile 2m 25s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 cc 2m 25s the patch passed
+1 💚 golang 2m 25s the patch passed
+1 💚 javac 2m 25s the patch passed
+1 💚 mvnsite 0m 19s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 17m 40s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 9m 16s hadoop-hdfs-native-client in the patch passed.
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
86m 36s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/2/artifact/out/Dockerfile
GITHUB PR #2151
Optional Tests dupname asflicense compile cc mvnsite javac unit golang
uname Linux b3bff816ec7e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 9965516
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.7+10-post-Ubuntu-2ubuntu218.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/2/testReport/
Max. process+thread count 335 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2151/2/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@surendralilhore
Copy link
Contributor

+1

@surendralilhore surendralilhore merged commit 4101b0c into apache:trunk Jul 19, 2020
@surendralilhore
Copy link
Contributor

Thanks @surajj-naik for contribution and @GauthamBanasandra for review

@surnaik surnaik deleted the fix-boost branch July 23, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants