Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-15525. Make trash root inside each snapshottable directory for WebHDFS #2220

Merged
merged 4 commits into from
Aug 18, 2020
Merged

HDFS-15525. Make trash root inside each snapshottable directory for WebHDFS #2220

merged 4 commits into from
Aug 18, 2020

Conversation

smengcl
Copy link
Contributor

@smengcl smengcl commented Aug 12, 2020 •
edited
Loading

https://issues.apache.org/jira/browse/HDFS-15525

Added new test TestWebHDFS#testGetSnapshotTrashRoot.

@smengcl
Patch NamenodeWebHdfsMethods#getTrashRoot.
c9f0ac3 
Change-Id: I2f4d818b342add60fd0da6514196237f95046f06
@smengcl
Improve path selection logic readability.
f6da4aa 
Change-Id: Id6469f43ace030d62a0da6e5d6c4cc689babbfe3
@smengcl
ssRoot could return null.
903704c 
Change-Id: I7845ae4df5233eba5dd2b6245b53a457f8e68446
@smengcl
Add testGetSnapshotTrashRoot.
904f104 
Change-Id: I9fe94a3290e3cab84aa852aa01c9dc104c10d065
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 28m 36s trunk passed
+1 💚 compile 1m 16s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 1m 10s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 0m 51s trunk passed
+1 💚 mvnsite 1m 16s trunk passed
+1 💚 shadedclient 16m 7s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 52s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 26s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 3m 1s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 58s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 5s the patch passed
+1 💚 compile 1m 7s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 1m 7s the patch passed
+1 💚 compile 1m 1s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 1m 1s the patch passed
+1 💚 checkstyle 0m 42s the patch passed
+1 💚 mvnsite 1m 7s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 50s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 46s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 24s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 3m 10s the patch passed
_ Other Tests _
-1 ❌ unit 122m 3s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
204m 30s
Reason Tests
Failed junit tests hadoop.hdfs.TestFileAppend
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
hadoop.hdfs.server.datanode.TestBPOfferService
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2220/1/artifact/out/Dockerfile
GITHUB PR #2220
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux ae757e2712a5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 141c625
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2220/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2220/1/testReport/
Max. process+thread count 3539 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2220/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 51s trunk passed
+1 💚 compile 1m 33s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 1m 20s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 1m 0s trunk passed
+1 💚 mvnsite 1m 26s trunk passed
+1 💚 shadedclient 19m 19s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 58s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 31s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 3m 40s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 37s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 16s the patch passed
+1 💚 compile 1m 25s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 1m 25s the patch passed
+1 💚 compile 1m 9s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 1m 9s the patch passed
+1 💚 checkstyle 0m 51s the patch passed
+1 💚 mvnsite 1m 15s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 27s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 47s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 17s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 3m 3s the patch passed
_ Other Tests _
-1 ❌ unit 97m 39s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
194m 32s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.server.datanode.TestBPOfferService
hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
hadoop.hdfs.TestMultipleNNPortQOP
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2220/2/artifact/out/Dockerfile
GITHUB PR #2220
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux fb24c3802307 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 141c625
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2220/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2220/2/testReport/
Max. process+thread count 4430 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2220/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

iwasakims
iwasakims approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@iwasakims iwasakims merged commit b65e43f into apache:trunk Aug 18, 2020
@iwasakims
Copy link
Member

I merged this. Thanks, @smengcl.

@smengcl
Copy link
Contributor Author

smengcl commented Aug 24, 2020

Thank you @iwasakims for reviewing and merging this!

jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@smengcl @mukul1987
HDFS-15525. Make trash root inside each snapshottable directory for W…
5466d78 
…ebHDFS (apache#2220)

(cherry picked from commit b65e43f)
Change-Id: I606eb2dfe9ae7a386dde444b740bd3395010a945
(cherry picked from commit c0e4833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwasakims iwasakims iwasakims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@smengcl @hadoop-yetus @iwasakims