Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17294. Fix typos existance to existence #2357

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

eltociear
Copy link
Contributor

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@tasanuma
Copy link
Member

tasanuma commented Oct 5, 2020

@eltociear Thanks for the PR.
Could you also fix it in HadoopArchiveLogs.md?

$ grep existance ./hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md
to prevent conflicts. It does this by checking for the existance of a

@tasanuma tasanuma changed the title HADOOP-17294. Fix typo in comment HADOOP-17294. Fix typos existance to existence Oct 5, 2020
@eltociear
Copy link
Contributor Author

@tasanuma Thank you for your announcement. I'll fix it.

@eltociear
Copy link
Contributor Author

@tasanuma I've fix HadoopArchiveLogs.md.
Please re-review my PR.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 5m 44s Maven dependency ordering for branch
+1 💚 mvninstall 31m 6s trunk passed
+1 💚 compile 30m 3s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 24m 25s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 4m 0s trunk passed
+1 💚 mvnsite 1m 34s trunk passed
+1 💚 shadedclient 23m 36s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 24s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 16s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 0m 56s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 21s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for patch
+1 💚 mvninstall 1m 7s the patch passed
+1 💚 compile 28m 48s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 28m 48s the patch passed
+1 💚 compile 24m 50s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 24m 50s the patch passed
+1 💚 checkstyle 3m 37s the patch passed
+1 💚 mvnsite 1m 34s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 17m 26s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 21s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 13s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 2m 45s the patch passed
_ Other Tests _
-1 ❌ unit 10m 33s /patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 1m 15s hadoop-archive-logs in the patch passed.
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
222m 36s
Reason Tests
Failed junit tests hadoop.mapreduce.v2.app.rm.TestRMCommunicator
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2357/2/artifact/out/Dockerfile
GITHUB PR #2357
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint
uname Linux 3bf2580c7bd4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 43b0c0b
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2357/2/testReport/
Max. process+thread count 566 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-tools/hadoop-archive-logs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2357/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed test is not related. +1.

@tasanuma tasanuma merged commit 4347a5c into apache:trunk Oct 6, 2020
@tasanuma
Copy link
Member

tasanuma commented Oct 6, 2020

Merged to trunk. Thanks for your contribution, @eltociear!

@eltociear
Copy link
Contributor Author

@tasanuma Thank you for your reviewing!

@eltociear eltociear deleted the HADOOP-17294 branch October 6, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants