HDFS-15654. TestBPOfferService#testMissBlocksWhenReregister fails intermittently #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Oct 28, 2020
| @@ -280,26 +282,24 @@ public void testBasicFunctionality() throws Exception { | |||
| */ | |||
| @Test | |||
| public void testMissBlocksWhenReregister() throws Exception { | |||
|
|
|||
goiri
reviewed
Oct 28, 2020
| LOG.error("Timed out wait for IBR counts FBRCount = {}," | ||
| + " IBRCount = {}; expected = {}", | ||
| fullBlockReportCount, incrBlockReportCount, totalTestBlocks); | ||
| Assert.fail(); |
There was a problem hiding this comment.
You might want to put the previous log message in the fail().
There was a problem hiding this comment.
And do the static import of fail() as the other assertEquals() and so on.
|
💔 -1 overall
This message was automatically generated. |
amahussein
force-pushed
the
hdfs-15654
branch
from
d05e70d
to
f22a94a
Compare
|
This LGTM. @amahussein good to merge? |
yes, this is good to go. Thanks @goiri |
|
💔 -1 overall
This message was automatically generated. |
4 tasks
xinglin
pushed a commit
to xinglin/hadoop
that referenced
this pull request
Oct 28, 2022
…ermittently (apache#2419) (cherry picked from commit 3248791)
asfgit
pushed a commit
that referenced
this pull request
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ermittently
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute