HDFS-15817. Rename snapshots while marking them deleted. #2677

bshashikant · 2021-02-03T13:46:34Z

Please see https://issues.apache.org/jira/browse/HDFS-15817 for details.

hadoop-yetus · 2021-02-03T18:27:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 24s		trunk passed
+1 💚	compile	1m 21s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 16s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	0m 58s		trunk passed
+1 💚	mvnsite	1m 22s		trunk passed
+1 💚	shadedclient	15m 13s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 53s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 29s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	3m 13s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 11s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 12s		the patch passed
+1 💚	compile	1m 17s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 17s		the patch passed
+1 💚	compile	1m 10s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	1m 10s		the patch passed
-0 ⚠️	checkstyle	0m 57s	/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 28 unchanged - 0 fixed = 34 total (was 28)
+1 💚	mvnsite	1m 17s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	12m 43s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 52s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 28s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	3m 16s		the patch passed
			_ Other Tests _
-1 ❌	unit	192m 54s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		279m 18s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/1/artifact/out/Dockerfile
GITHUB PR	#2677
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 7544dcf31cf5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `66ecee3`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/1/testReport/
Max. process+thread count	2879 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/1/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-02-04T21:41:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	89m 46s		trunk passed
+1 💚	compile	1m 26s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 30s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 20s		trunk passed
+1 💚	mvnsite	1m 39s		trunk passed
+1 💚	shadedclient	19m 58s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 8s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 45s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	3m 54s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 50s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 30s		the patch passed
+1 💚	compile	1m 32s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 32s		the patch passed
+1 💚	compile	1m 24s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	1m 24s		the patch passed
+1 💚	checkstyle	1m 5s		the patch passed
+1 💚	mvnsite	1m 27s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	17m 47s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 59s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 34s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	4m 9s		the patch passed
			_ Other Tests _
-1 ❌	unit	209m 30s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		366m 46s

Reason	Tests
Failed junit tests	hadoop.hdfs.tools.TestViewFileSystemOverloadSchemeWithDFSAdmin
	hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
	hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
	hadoop.hdfs.server.namenode.snapshot.TestOrderedSnapshotDeletionGc

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/2/artifact/out/Dockerfile
GITHUB PR	#2677
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 8829bc4f5317 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5f34271`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/2/testReport/
Max. process+thread count	2940 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/2/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

…ame.

bshashikant · 2021-02-05T07:53:24Z

Appending a timestamp to the deleted snapshot name may lead to different names being generated pre and post restart of namenode during edit log replay. Therefore, the idea here is to just append the snapshot Id which will remain constant.

@szetszwo , can you have a look.

szetszwo

There are a few whitespace changes. Otherwise, the change look good.

hadoop-yetus · 2021-02-05T12:09:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 18s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	42m 12s		trunk passed
+1 💚	compile	2m 0s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 39s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 20s		trunk passed
+1 💚	mvnsite	1m 47s		trunk passed
+1 💚	shadedclient	23m 12s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 18s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 43s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	4m 20s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 13s		trunk passed
			_ Patch Compile Tests _
-1 ❌	mvninstall	0m 49s	/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
-1 ❌	compile	0m 56s	/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04.txt	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04.
-1 ❌	javac	0m 56s	/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04.txt	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04.
-1 ❌	compile	0m 56s	/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt	hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.
-1 ❌	javac	0m 56s	/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.txt	hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01.
+1 💚	checkstyle	1m 6s		the patch passed
-1 ❌	mvnsite	0m 50s	/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
-1 ❌	shadedclient	3m 21s		patch has errors when building and testing our client artifacts.
+1 💚	javadoc	0m 49s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 19s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
-1 ❌	findbugs	0m 43s	/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
			_ Other Tests _
-1 ❌	unit	0m 43s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
+1 💚	asflicense	0m 26s		The patch does not generate ASF License warnings.
		94m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/4/artifact/out/Dockerfile
GITHUB PR	#2677
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 13ebafc3a9b0 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `65857ea`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/4/testReport/
Max. process+thread count	508 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/4/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-02-05T12:38:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 37s		trunk passed
+1 💚	compile	1m 26s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 17s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 1s		trunk passed
+1 💚	mvnsite	1m 28s		trunk passed
+1 💚	shadedclient	17m 33s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 0s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 34s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	3m 20s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 18s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 13s		the patch passed
+1 💚	compile	1m 18s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 18s		the patch passed
+1 💚	compile	1m 9s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	1m 9s		the patch passed
+1 💚	checkstyle	0m 58s		the patch passed
+1 💚	mvnsite	1m 13s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	14m 57s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 54s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 27s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	3m 27s		the patch passed
			_ Other Tests _
-1 ❌	unit	195m 3s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 44s		The patch does not generate ASF License warnings.
		288m 3s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/3/artifact/out/Dockerfile
GITHUB PR	#2677
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 3db44fa108f6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `65857ea`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/3/testReport/
Max. process+thread count	3240 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/3/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

szetszwo · 2021-02-07T13:20:01Z

@bshashikant , the commit 99efed3 did not fix any whitespace changes. The changes might be done by your IDE. I suggest to use VI or other editors to revert those changes.

mukul1987

The changes generally look good. However, if a user again deletes a deleted snapshot with the new name(which was given because of this rename. Can we lead into concats of the snapid ?

bshashikant · 2021-02-08T06:29:44Z

The changes generally look good. However, if a user again deletes a deleted snapshot with the new name(which was given because of this rename. Can we lead into concats of the snapid ?

Yes, it will append the snap id. The behaviour will be same if user for example, creates a snapshot with the same name as snapshot format and deletes it . I guess, this should be fine as marked for deleted snapshots are user visible and can be deleted again and again until and unless it gets permanently deleted.

hadoop-yetus · 2021-02-08T12:12:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 22s		trunk passed
+1 💚	compile	1m 25s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 16s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 2s		trunk passed
+1 💚	mvnsite	1m 29s		trunk passed
+1 💚	shadedclient	18m 24s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 55s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 32s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	3m 18s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 16s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 17s		the patch passed
+1 💚	compile	1m 17s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 17s		the patch passed
+1 💚	compile	1m 10s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	1m 10s		the patch passed
+1 💚	checkstyle	0m 59s		the patch passed
+1 💚	mvnsite	1m 14s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	14m 41s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 56s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 25s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	3m 24s		the patch passed
			_ Other Tests _
-1 ❌	unit	193m 51s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		287m 54s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/5/artifact/out/Dockerfile
GITHUB PR	#2677
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 91a9de5b8392 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `19ae0fa`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/5/testReport/
Max. process+thread count	3039 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/5/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

szetszwo

+1 the change looks good.

hadoop-yetus · 2021-02-08T21:17:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 27s		trunk passed
+1 💚	compile	1m 27s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 21s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 28s		trunk passed
+1 💚	shadedclient	15m 39s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 56s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 27s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	3m 5s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 3s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 13s		the patch passed
+1 💚	compile	1m 11s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 11s		the patch passed
+1 💚	compile	1m 5s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	1m 5s		the patch passed
+1 💚	checkstyle	0m 53s		the patch passed
+1 💚	mvnsite	1m 12s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	12m 39s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 49s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 22s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	3m 7s		the patch passed
			_ Other Tests _
-1 ❌	unit	200m 36s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		287m 41s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
	hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/6/artifact/out/Dockerfile
GITHUB PR	#2677
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux cd5368a3c33e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `19ae0fa`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/6/testReport/
Max. process+thread count	3508 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2677/6/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

bshashikant · 2021-02-09T04:58:20Z

Thanks @mukul1987 and @bshashikant for the review.

(cherry picked from commit 2df2dfb Ref: OPSAPS-59302. Snapshot based replication doesn't work with ordered snapshot deletion feature turned on Change-Id: I037fbc24f71150c26f90eb12a41073e2a9e0820c

HDFS-15817. Rename snapshots while marking them deleted.

3769e1e

bshashikant requested a review from szetszwo February 3, 2021 13:46

Addressed review comments.

730a991

Removed use of deletion timestamp while generating deleted snapshot n…

a1ffdd3

…ame.

szetszwo reviewed Feb 5, 2021

View reviewed changes

Fixed unintentended whitespace changes..

99efed3

mukul1987 reviewed Feb 7, 2021

View reviewed changes

Removed unintended whitespace chnages.

12998c9

szetszwo approved these changes Feb 8, 2021

View reviewed changes

mukul1987 approved these changes Feb 9, 2021

View reviewed changes

bshashikant merged commit 2df2dfb into apache:trunk Feb 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-15817. Rename snapshots while marking them deleted. #2677

HDFS-15817. Rename snapshots while marking them deleted. #2677

bshashikant commented Feb 3, 2021

hadoop-yetus commented Feb 3, 2021

hadoop-yetus commented Feb 4, 2021

bshashikant commented Feb 5, 2021

szetszwo left a comment

hadoop-yetus commented Feb 5, 2021

hadoop-yetus commented Feb 5, 2021

szetszwo commented Feb 7, 2021

mukul1987 left a comment

bshashikant commented Feb 8, 2021

hadoop-yetus commented Feb 8, 2021

szetszwo left a comment

hadoop-yetus commented Feb 8, 2021

bshashikant commented Feb 9, 2021

HDFS-15817. Rename snapshots while marking them deleted. #2677

HDFS-15817. Rename snapshots while marking them deleted. #2677

Conversation

bshashikant commented Feb 3, 2021

hadoop-yetus commented Feb 3, 2021

hadoop-yetus commented Feb 4, 2021

bshashikant commented Feb 5, 2021

szetszwo left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Feb 5, 2021

hadoop-yetus commented Feb 5, 2021

szetszwo commented Feb 7, 2021

mukul1987 left a comment

Choose a reason for hiding this comment

bshashikant commented Feb 8, 2021

hadoop-yetus commented Feb 8, 2021

szetszwo left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Feb 8, 2021

bshashikant commented Feb 9, 2021