Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17586. Upgrade org.codehaus.woodstox:stax2-api to 4.2.1. #2769

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

ayushtkn
Copy link
Member

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding), pending QA

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 13s Maven dependency ordering for branch
+1 💚 mvninstall 26m 0s trunk passed
+1 💚 compile 20m 43s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 18m 16s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 mvnsite 27m 42s trunk passed
+1 💚 javadoc 8m 47s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 8m 48s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 shadedclient 33m 37s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
+1 💚 mvninstall 23m 1s the patch passed
+1 💚 compile 20m 52s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 20m 52s the patch passed
+1 💚 compile 18m 26s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 18m 26s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 20m 19s the patch passed
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 7m 31s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 7m 53s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 shadedclient 30m 7s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 683m 57s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 51s The patch does not generate ASF License warnings.
943m 14s
Reason Tests
Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.TestViewDistributedFileSystem
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.yarn.server.router.clientrm.TestFederationClientInterceptor
hadoop.tools.dynamometer.TestDynamometerInfra
hadoop.yarn.sls.appmaster.TestAMSimulator
hadoop.yarn.sls.TestReservationSystemInvariants
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2769/1/artifact/out/Dockerfile
GITHUB PR #2769
Optional Tests dupname asflicense codespell shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux 2f13dd912c31 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / eb35640
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2769/1/testReport/
Max. process+thread count 3650 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2769/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@ayushtkn
Copy link
Member Author

Thanx @liuml07 and @virajjasani for the review.
TestConfTest passed here:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2769/1/testReport/org.apache.hadoop.util/TestConfTest/

The other failing tests aren't related, Tried locally:
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.yarn.sls.TestReservationSystemInvariants
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 186.538 s - in org.apache.hadoop.yarn.sls.TestReservationSystemInvariants
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.yarn.sls.appmaster.TestAMSimulator
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.181 s - in org.apache.hadoop.yarn.sls.appmaster.TestAMSimulator
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0

[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.yarn.server.router.clientrm.TestFederationClientInterceptor
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.778 s - in org.apache.hadoop.yarn.server.router.clientrm.TestFederationClientInterceptor
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0

[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.TestViewDistributedFileSystem
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.07 s - in org.apache.hadoop.hdfs.TestViewDistributedFileSystem
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

TestDynamometerInfra is broken since some time there is a jira tracking that, TestBalancerWithHANameNodes and TestReconstructStripedFileWithRandomECPolicy are known flaky HDFS tests

@ayushtkn ayushtkn merged commit 167603b into apache:trunk Mar 13, 2021
asfgit pushed a commit that referenced this pull request Mar 13, 2021
…. Contributed by Ayush Saxena.

Signed-off-by: Mingliang Liu <liuml07@apache.org>
 Conflicts:
	LICENSE-binary
asfgit pushed a commit that referenced this pull request Mar 13, 2021
…. Contributed by Ayush Saxena.

Signed-off-by: Mingliang Liu <liuml07@apache.org>
 Conflicts:
	LICENSE-binary
asfgit pushed a commit that referenced this pull request Mar 13, 2021
…. Contributed by Ayush Saxena.

Signed-off-by: Mingliang Liu <liuml07@apache.org>
 Conflicts:
	LICENSE-binary
asfgit pushed a commit that referenced this pull request Mar 13, 2021
…. Contributed by Ayush Saxena.

Signed-off-by: Mingliang Liu <liuml07@apache.org>
@ayushtkn
Copy link
Member Author

Merged PR, Thanx @liuml07 and @virajjasani for the reviews!!!

@liuml07
Copy link
Member

liuml07 commented Mar 13, 2021

Thanks for fixing this. Do we need to backport this into other branches?

@ayushtkn
Copy link
Member Author

Hey @liuml07,
I already cherry-picked this to all branches till 2.10 while merging,
Did I accidentally missed some branch or did something wrong?

@liuml07
Copy link
Member

liuml07 commented Mar 13, 2021

No, thanks!

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
…he#2769). Contributed by Ayush Saxena.

Signed-off-by: Mingliang Liu <liuml07@apache.org>
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…4.2.1. (apache#2769). Contributed by Ayush Saxena.

Signed-off-by: Mingliang Liu <liuml07@apache.org>
(cherry picked from commit 28e8950)
Change-Id: I9c58cb180b392613990e737c3547e7c0dc0d66fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants