Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-15916. DistCp: Backward compatibility: Distcp fails from Hadoop 3 to Hadoop 2 for snapshotdiff. (#2863). Contributed by Ayush Saxena. #3054

Merged
merged 1 commit into from Jun 9, 2021
Merged

HDFS-15916. DistCp: Backward compatibility: Distcp fails from Hadoop 3 to Hadoop 2 for snapshotdiff. (#2863). Contributed by Ayush Saxena. #3054

merged 1 commit into from Jun 9, 2021

Conversation

jojochuang
Copy link
Contributor

Signed-off-by: Wei-Chiu Chuang weichiu@apache.org
(cherry picked from commit c6539e3)

Conflicts:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java

@ayushtkn @jojochuang
HDFS-15916. DistCp: Backward compatibility: Distcp fails from Hadoop …
705efa2 
…3 to Hadoop 2 for snapshotdiff. (apache#2863). Contributed by Ayush Saxena.

Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit c6539e3)

 Conflicts:
	hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
jojochuang
jojochuang commented May 26, 2021
View reviewed changes
...s-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
} catch (RpcNoSuchMethodException e) {
// In case the server doesn't support getSnapshotDiffReportListing,
// fallback to getSnapshotDiffReport.
DFSClient.LOG.warn("Falling back to getSnapshotDiffReport {}", e.getMessage());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to use DFSClient.LOG instead of FileSystem.LOG because FileSystem in 3.3 uses commons-logging, not slf4, and does not compile. DFSClient.LOG uses slf4j.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 11m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 31m 32s branch-3.3 passed
+1 💚 compile 0m 50s branch-3.3 passed
+1 💚 checkstyle 0m 23s branch-3.3 passed
+1 💚 mvnsite 0m 56s branch-3.3 passed
+1 💚 javadoc 0m 36s branch-3.3 passed
+1 💚 spotbugs 2m 31s branch-3.3 passed
+1 💚 shadedclient 19m 36s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 48s the patch passed
+1 💚 compile 0m 45s the patch passed
+1 💚 javac 0m 45s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 16s /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-client.txt hadoop-hdfs-project/hadoop-hdfs-client: The patch generated 1 new + 18 unchanged - 0 fixed = 19 total (was 18)
+1 💚 mvnsite 0m 48s the patch passed
+1 💚 javadoc 0m 28s the patch passed
+1 💚 spotbugs 2m 38s the patch passed
+1 💚 shadedclient 19m 47s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 8s hadoop-hdfs-client in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
94m 9s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3054/1/artifact/out/Dockerfile
GITHUB PR #3054
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 4c32034089a3 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 705efa2
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3054/1/testReport/
Max. process+thread count 513 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3054/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jojochuang jojochuang merged commit 83d119f into apache:branch-3.3 Jun 9, 2021
@jojochuang
Copy link
Contributor Author

Merging it. No test failures.

jojochuang added a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@jojochuang
CDPD-30300 Review HDFS defects targetted for 7.1.8 and re-prioritize …
9854430 
…few important for 7.1.7 SP1

Upstream JIRA ID:
HDFS-15916. DistCp: Backward compatibility: Distcp fails from Hadoop 3 to Hadoop 2 for snapshotdiff. (apache#2863). Contributed by Ayush Saxena. (apache#3054)

Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit c6539e3)

Co-authored-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 83d119f)

Change-Id: Ie833e49e2baf532f48d8fbeb325f34c0f632664e
(cherry picked from commit 1e8f156add11e19b1524ee96004b1eacf71e8a18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jojochuang @hadoop-yetus @ayushtkn