Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YARN-10803. [JDK 11] TestRMFailoverProxyProvider and TestNoHaRMFailoverProxyProvider fails by ClassCastException #3068

Merged
merged 1 commit into from Jun 10, 2021
Merged

YARN-10803. [JDK 11] TestRMFailoverProxyProvider and TestNoHaRMFailoverProxyProvider fails by ClassCastException #3068

merged 1 commit into from Jun 10, 2021

Conversation

aajisaka
Copy link
Member

@aajisaka aajisaka commented Jun 3, 2021

The class definitions are wrong in some variables. Fixed.

JIRA: YARN-10803

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 17s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
-1 ❌ mvninstall 4m 43s /branch-mvninstall-root.txt root in trunk failed.
+1 💚 compile 3m 5s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 0m 25s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 checkstyle 0m 19s trunk passed
+1 💚 mvnsite 0m 32s trunk passed
+1 💚 javadoc 0m 28s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 21s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 0m 53s trunk passed
+1 💚 shadedclient 18m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 31s the patch passed
+1 💚 compile 0m 30s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
-1 ❌ javac 0m 30s /results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04.txt hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkUbuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 generated 1 new + 9 unchanged - 10 fixed = 10 total (was 19)
+1 💚 compile 0m 27s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
-1 ❌ javac 0m 27s /results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08.txt hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdkPrivateBuild-1.8.0_282-8u282-b08-0ubuntu120.04-b08 with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu120.04-b08 generated 1 new + 9 unchanged - 10 fixed = 10 total (was 19)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 18s the patch passed
+1 💚 mvnsite 0m 28s the patch passed
+1 💚 javadoc 0m 23s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 0m 19s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 1m 1s the patch passed
+1 💚 shadedclient 16m 55s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 27m 48s hadoop-yarn-client in the patch passed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
81m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3068/1/artifact/out/Dockerfile
GITHUB PR #3068
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 2cebb3d05ae1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d389ce5
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3068/1/testReport/
Max. process+thread count 744 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3068/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

bogthe
bogthe approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@bogthe bogthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aajisaka
Copy link
Member Author

aajisaka commented Jun 8, 2021

Thank you @bogthe!

@tasanuma Would you review this?

@aajisaka aajisaka requested a review from tasanuma June 8, 2021 12:15
@tasanuma tasanuma changed the title YARN-10803. [JDK 11] TestRMFailoverProxyProvider and TestNoHaRMFailoverProxyProvier fails by ClassCastException YARN-10803. [JDK 11] TestRMFailoverProxyProvider and TestNoHaRMFailoverProxyProvider fails by ClassCastException Jun 9, 2021
tasanuma
tasanuma approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the unit tests succeeds with this PR on JDK11. LGTM.

@bogthe
Copy link
Contributor

bogthe commented Jun 9, 2021

@aajisaka reviewed it, pulled the changes locally and everything works! 👍

@aajisaka aajisaka merged commit 9a17f97 into apache:trunk Jun 10, 2021
@aajisaka
Copy link
Member Author

Merged. Thank you @tasanuma and @bogthe

@aajisaka aajisaka deleted the YARN-10803 branch June 10, 2021 05:30
aajisaka added a commit that referenced this pull request Jun 10, 2021
@aajisaka
YARN-10803. [JDK 11] TestRMFailoverProxyProvider and TestNoHaRMFailov…
19c9699 
…erProxyProvider fails by ClassCastException. (#3068)

Reviewed-by: Takanobu Asanuma <tasanuma@apache.org>
(cherry picked from commit 9a17f97)
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@aajisaka
YARN-10803. [JDK 11] TestRMFailoverProxyProvider and TestNoHaRMFailov…
9e0615b 
…erProxyProvider fails by ClassCastException. (apache#3068)

Reviewed-by: Takanobu Asanuma <tasanuma@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasanuma tasanuma tasanuma approved these changes

@bogthe bogthe bogthe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@aajisaka @hadoop-yetus @bogthe @tasanuma