Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAPREDUCE-7354. Use empty array constant present in TaskCompletionEvent to avoid creating redundant objects #3123

Merged
merged 2 commits into from Jun 21, 2021
Merged

MAPREDUCE-7354. Use empty array constant present in TaskCompletionEvent to avoid creating redundant objects #3123

merged 2 commits into from Jun 21, 2021

Conversation

virajjasani
Copy link
Contributor

No description provided.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 21m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 33s Maven dependency ordering for branch
+1 💚 mvninstall 23m 41s trunk passed
+1 💚 compile 2m 33s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 2m 9s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 0m 58s trunk passed
+1 💚 mvnsite 1m 41s trunk passed
+1 💚 javadoc 1m 13s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 7s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 0s trunk passed
+1 💚 shadedclient 16m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 1m 25s the patch passed
+1 💚 compile 2m 29s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 2m 29s the patch passed
+1 💚 compile 2m 2s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 2m 2s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 51s /results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 111 unchanged - 0 fixed = 112 total (was 111)
+1 💚 mvnsite 1m 24s the patch passed
+1 💚 javadoc 0m 57s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 52s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 15s the patch passed
+1 💚 shadedclient 16m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 7m 0s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 8m 15s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 5m 12s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
140m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3123/1/artifact/out/Dockerfile
GITHUB PR #3123
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 3388c2519752 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 4be88c9
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3123/1/testReport/
Max. process+thread count 1114 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3123/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani mentioned this pull request Jun 19, 2021
Merged
tasanuma
tasanuma approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tasanuma
Copy link
Member

Sorry, could you fix the checkstyle issue? @virajjasani

@virajjasani
Copy link
Contributor Author

Ah missed it, sorry. Since checkstyles are usually -0 and not -1, I usually miss them :)

@virajjasani
Copy link
Contributor Author

Done, Thank you @tasanuma

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 34s Maven dependency ordering for branch
+1 💚 mvninstall 24m 43s trunk passed
+1 💚 compile 2m 34s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 2m 7s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 0m 58s trunk passed
+1 💚 mvnsite 1m 42s trunk passed
+1 💚 javadoc 1m 13s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 9s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 0s trunk passed
+1 💚 shadedclient 16m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 mvninstall 1m 25s the patch passed
+1 💚 compile 2m 26s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 2m 26s the patch passed
+1 💚 compile 2m 3s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 2m 3s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 50s the patch passed
+1 💚 mvnsite 1m 25s the patch passed
+1 💚 javadoc 0m 56s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 52s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 3m 18s the patch passed
+1 💚 shadedclient 16m 32s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 7m 3s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 8m 12s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 5m 8s hadoop-mapreduce-client-hs in the patch passed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
120m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3123/2/artifact/out/Dockerfile
GITHUB PR #3123
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux ed0e5c495de3 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 353f399
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3123/2/testReport/
Max. process+thread count 1107 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3123/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tasanuma tasanuma merged commit 6e11461 into apache:trunk Jun 21, 2021
@tasanuma
Copy link
Member

Merged. Thanks for your contribution, @virajjasani.
Thanks for your reviews, @ferhui and @aajisaka.

tasanuma pushed a commit that referenced this pull request Jun 21, 2021
@virajjasani @tasanuma
MAPREDUCE-7354. Use empty array constant present in TaskCompletionEve…
4825c7c 
…nt to avoid creating redundant objects (#3123)

Reviewed-by: Hui Fei <ferhui@apache.org>
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit 6e11461)
@virajjasani virajjasani deleted the MAPREDUCE-7354-trunk branch June 21, 2021 15:12
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@virajjasani
MAPREDUCE-7354. Use empty array constant present in TaskCompletionEve…
9786414 
…nt to avoid creating redundant objects (apache#3123)

Reviewed-by: Hui Fei <ferhui@apache.org>
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhui ferhui ferhui approved these changes

@aajisaka aajisaka aajisaka approved these changes

@tasanuma tasanuma tasanuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@virajjasani @hadoop-yetus @tasanuma @ferhui @aajisaka