Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YARN-10931.Remove some invalid characters in NMClientAsyncImpl#ContainerState. #3365

Closed
wants to merge 1 commit into from
Closed

YARN-10931.Remove some invalid characters in NMClientAsyncImpl#ContainerState. #3365

wants to merge 1 commit into from

Conversation

jianghuazhu
Copy link
Contributor

@jianghuazhu jianghuazhu commented Sep 1, 2021 •
edited

…nerState.

jira:YARN-10931

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 31m 15s trunk passed
+1 💚 compile 0m 36s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 0m 34s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 0m 32s trunk passed
+1 💚 mvnsite 0m 38s trunk passed
+1 💚 javadoc 0m 31s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 29s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 5m 54s trunk passed
+1 💚 shadedclient 18m 58s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 29s the patch passed
+1 💚 compile 0m 28s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 0m 28s the patch passed
+1 💚 compile 0m 25s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 0m 25s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 17s the patch passed
+1 💚 mvnsite 0m 27s the patch passed
+1 💚 javadoc 0m 21s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 19s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 0m 56s the patch passed
+1 💚 shadedclient 13m 50s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 27m 45s hadoop-yarn-client in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
102m 31s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3365/1/artifact/out/Dockerfile
GITHUB PR #3365
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux a5f5251418b5 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / cfe361d
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3365/1/testReport/
Max. process+thread count 555 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3365/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jianghuazhu
Copy link
Contributor Author

@tangzhankun @zhuqi-lucas , can you help review the code.
thank you very much.

@jianghuazhu
Copy link
Contributor Author

It seems that UT has failed to execute, but from the details, I can't see where the problem is.
Can someone help analyze it together.
thank you very much.

ayushtkn
ayushtkn reviewed Sep 3, 2021
View reviewed changes
...arn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
@@ -433,7 +433,7 @@ public void getContainerStatusAsync(ContainerId containerId, NodeId nodeId) {
}

protected enum ContainerState {
PREP, FAILED, RUNNING, DONE,
PREP, FAILED, RUNNING, DONE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, what harm is this comma causing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayushtkn for the comment. I found that in most places in Hadoop projects, when enum is defined, the last element usually does not have any symbol, so I think the same style needs to be maintained here. This is my idea.
Welcome to continue to communicate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree with @ayushtkn, also this comma doesn't qualify for an invalid character.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szilard-nemeth for the comment and review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szilard-nemeth szilard-nemeth szilard-nemeth left review comments

@ayushtkn ayushtkn ayushtkn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jianghuazhu @hadoop-yetus @szilard-nemeth @ayushtkn