Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17908. Add missing RELEASENOTES and CHANGELOG to upstream. #3433

Merged
merged 2 commits into from Oct 20, 2021

Conversation

iwasakims
Copy link
Member

https://issues.apache.org/jira/browse/HADOOP-17908

RELEASENOTES and CHANGELOG of 2.10.1, 3.1.4 and 3.3.0 are missing in trunk.

While CHANGES* were renamed to CHANGELOG* by HADOOP-14671, there are some CHANGES files left. I would like to rename those to CHNAGELOG here for consistency.

$ find . -name 'CHANGES*'
./hadoop-common-project/hadoop-common/src/site/markdown/release/2.10.0/CHANGES.2.10.0.md
./hadoop-common-project/hadoop-common/src/site/markdown/release/3.1.2/CHANGES.3.1.2.md
./hadoop-common-project/hadoop-common/src/site/markdown/release/3.1.3/CHANGES.3.1.3.md

hadoop-common-project/hadoop-common/src/site/markdown/release/2.10.0 contains both CHANGES.2.10.0.md and CHANGELOG.2.10.0.md. Since the contents of current CHANGELOG.2.10.0.md is invalid, I replaced it with the contents of current CHANGES.2.10.0.md (and removed the CHANGES.2.10.0.md).

HTML files under "Changelog and Release Notes" pages (hadoop-project/hadoop-project-dist/hadoop-common/release/*) are generated by mvn site regardless of the file names.

@iwasakims
Copy link
Member Author

iwasakims commented Sep 14, 2021

I would like to rename those to CHNAGELOG here for consistency.

Scripts (of Yetus) seem to expect CHANGELOG.
https://github.com/apache/hadoop/blob/trunk/dev-support/bin/create-release#L623-L628

@iwasakims
Copy link
Member Author

Generated index.html of "Changelog and Release Notes" (hadoop-project/hadoop-project-dist/hadoop-common/release/index.html) can be verified by building docs with -Preleasedocs like

$ mvn site site:stage -Preleasedocs -DstagingDirectory=/var/www/html/hadoop-site/trunk

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 34m 34s trunk passed
+1 💚 mvnsite 1m 56s trunk passed
+1 💚 shadedclient 58m 28s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 45s the patch passed
-1 ❌ blanks 0m 0s /blanks-eol.txt The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 mvnsite 2m 11s the patch passed
+1 💚 shadedclient 24m 15s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 48s The patch does not generate ASF License warnings.
88m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3433/1/artifact/out/Dockerfile
GITHUB PR #3433
Optional Tests dupname asflicense mvnsite codespell markdownlint
uname Linux 4e3aef186475 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 8e104c2
Max. process+thread count 594 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3433/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 56s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 31m 49s trunk passed
+1 💚 mvnsite 1m 21s trunk passed
+1 💚 shadedclient 46m 40s branch has no errors when building and testing our client artifacts.
-0 ⚠️ patch 46m 59s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 56s the patch passed
-1 ❌ blanks 0m 0s /blanks-eol.txt The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 mvnsite 1m 14s the patch passed
+1 💚 shadedclient 14m 33s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
65m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3433/2/artifact/out/Dockerfile
GITHUB PR #3433
Optional Tests dupname asflicense mvnsite codespell markdownlint
uname Linux ca151a4e7a42 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 5dff429
Max. process+thread count 719 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3433/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@iwasakims
Copy link
Member Author

The patch has 1 line(s) that end in blanks.

The relevant file (RELEASENOTES.3.3.0.md) are part of already published release artifacts. I think it should be added as is.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @iwasakims

@iwasakims iwasakims merged commit 46a7117 into apache:trunk Oct 20, 2021
@iwasakims
Copy link
Member Author

Thanks, @aajisaka. I merged this.

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants