You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1097
trunk passed
+1
compile
29
trunk passed
+1
checkstyle
19
trunk passed
+1
mvnsite
32
trunk passed
+1
shadedclient
691
branch has no errors when building and testing our client artifacts.
+1
javadoc
20
trunk passed
0
spotbugs
41
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
39
trunk passed
_ Patch Compile Tests _
+1
mvninstall
29
the patch passed
+1
compile
24
the patch passed
+1
javac
24
the patch passed
+1
checkstyle
14
the patch passed
+1
mvnsite
29
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
733
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1399
trunk passed
+1
compile
30
trunk passed
+1
checkstyle
23
trunk passed
+1
mvnsite
38
trunk passed
+1
shadedclient
909
branch has no errors when building and testing our client artifacts.
+1
javadoc
26
trunk passed
0
spotbugs
51
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
49
trunk passed
_ Patch Compile Tests _
+1
mvninstall
26
the patch passed
+1
compile
24
the patch passed
+1
javac
24
the patch passed
+1
checkstyle
16
the patch passed
+1
mvnsite
35
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
911
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1324
trunk passed
+1
compile
29
trunk passed
+1
checkstyle
20
trunk passed
+1
mvnsite
32
trunk passed
+1
shadedclient
786
branch has no errors when building and testing our client artifacts.
+1
javadoc
23
trunk passed
0
spotbugs
48
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
46
trunk passed
_ Patch Compile Tests _
+1
mvninstall
28
the patch passed
+1
compile
27
the patch passed
+1
javac
27
the patch passed
+1
checkstyle
15
the patch passed
+1
mvnsite
26
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
905
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1053
trunk passed
+1
compile
22
trunk passed
+1
checkstyle
16
trunk passed
+1
mvnsite
22
trunk passed
+1
shadedclient
656
branch has no errors when building and testing our client artifacts.
+1
javadoc
20
trunk passed
0
spotbugs
36
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
34
trunk passed
_ Patch Compile Tests _
+1
mvninstall
23
the patch passed
+1
compile
16
the patch passed
+1
javac
16
the patch passed
+1
checkstyle
14
the patch passed
+1
mvnsite
19
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
701
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1125
trunk passed
+1
compile
22
trunk passed
+1
checkstyle
16
trunk passed
+1
mvnsite
23
trunk passed
+1
shadedclient
694
branch has no errors when building and testing our client artifacts.
+1
javadoc
18
trunk passed
0
spotbugs
37
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
34
trunk passed
_ Patch Compile Tests _
+1
mvninstall
20
the patch passed
+1
compile
16
the patch passed
+1
javac
16
the patch passed
+1
checkstyle
12
the patch passed
+1
mvnsite
17
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
729
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1055
trunk passed
+1
compile
21
trunk passed
+1
checkstyle
16
trunk passed
+1
mvnsite
23
trunk passed
+1
shadedclient
685
branch has no errors when building and testing our client artifacts.
+1
javadoc
18
trunk passed
0
spotbugs
36
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
35
trunk passed
_ Patch Compile Tests _
+1
mvninstall
21
the patch passed
+1
compile
16
the patch passed
+1
javac
16
the patch passed
+1
checkstyle
11
the patch passed
+1
mvnsite
18
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
715
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1223
trunk passed
+1
compile
21
trunk passed
+1
checkstyle
16
trunk passed
+1
mvnsite
24
trunk passed
+1
shadedclient
849
branch has no errors when building and testing our client artifacts.
+1
javadoc
30
trunk passed
0
spotbugs
50
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
46
trunk passed
_ Patch Compile Tests _
+1
mvninstall
31
the patch passed
+1
compile
23
the patch passed
+1
javac
23
the patch passed
+1
checkstyle
16
the patch passed
+1
mvnsite
25
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
927
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1407
trunk passed
+1
compile
29
trunk passed
+1
checkstyle
20
trunk passed
+1
mvnsite
29
trunk passed
+1
shadedclient
966
branch has no errors when building and testing our client artifacts.
+1
javadoc
26
trunk passed
0
spotbugs
59
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
57
trunk passed
_ Patch Compile Tests _
+1
mvninstall
31
the patch passed
+1
compile
24
the patch passed
+1
javac
24
the patch passed
+1
checkstyle
18
the patch passed
+1
mvnsite
24
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
940
patch has no errors when building and testing our client artifacts.
A bunch of issues were found by BEAM tests, which includes:
1) WatermarkFunction needs to be able to return output after processWatermark()
2) control message doesn't implement the equals() and hashcode()
3) Some kafka system related code is not scala 2.10 compatible for tests.
Author: xiliu <xiliu@xiliu-ld1.linkedin.biz>
Reviewers: Prateek
Closesapache#345 from xinyuiscool/SAMZA-1477
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.