MAPREDUCE-7363. Rename JobClientUnitTest to TestJobClients #3487

dongjoon-hyun · 2021-09-26T23:44:09Z

Description of PR

This PR aims to rename a test class from JobClientUnitTest to TestJobClients for consistency.
Although this is a minor PR on test case, it's helpful for the downstream to manage the builds and tests.

How was this patch tested?

Pass the CI.

For code changes:

[v] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

dongjoon-hyun · 2021-09-27T00:00:19Z

...hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestJobClients.java

@@ -44,7 +44,7 @@
 import org.junit.Test;

 @SuppressWarnings("deprecation")
-public class JobClientUnitTest {
+public class TestJobClients {


This is TestJobClients to avoid conflicts with TestJobClient

dongjoon-hyun · 2021-09-27T00:00:35Z

cc @sunchao

hadoop-yetus · 2021-09-27T00:58:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 18s		trunk passed
+1 💚	compile	0m 45s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 36s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 36s		trunk passed
+1 💚	mvnsite	0m 39s		trunk passed
+1 💚	javadoc	0m 29s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 25s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 55s		trunk passed
+1 💚	shadedclient	19m 5s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
-1 ❌	mvninstall	0m 24s	/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt	hadoop-mapreduce-client-jobclient in the patch failed.
-1 ❌	compile	0m 28s	/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-mapreduce-client-jobclient in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	javac	0m 28s	/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt	hadoop-mapreduce-client-jobclient in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.
-1 ❌	compile	0m 24s	/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt	hadoop-mapreduce-client-jobclient in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.
-1 ❌	javac	0m 24s	/patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt	hadoop-mapreduce-client-jobclient in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 17 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	checkstyle	0m 26s		the patch passed
-1 ❌	mvnsite	0m 25s	/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt	hadoop-mapreduce-client-jobclient in the patch failed.
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-1 ❌	spotbugs	0m 26s	/patch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt	hadoop-mapreduce-client-jobclient in the patch failed.
-1 ❌	shadedclient	11m 49s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 29s	/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt	hadoop-mapreduce-client-jobclient in the patch failed.
+1 💚	asflicense	1m 18s		The patch does not generate ASF License warnings.
		73m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3487/1/artifact/out/Dockerfile
GITHUB PR	#3487
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux bdd0b9460625 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 405ecd3a91046a436ab44aa657e50419f7a6d8a2
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3487/1/testReport/
Max. process+thread count	550 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3487/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-09-27T03:28:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 19s		trunk passed
+1 💚	compile	0m 39s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 35s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 36s		trunk passed
+1 💚	mvnsite	0m 38s		trunk passed
+1 💚	javadoc	0m 29s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 26s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 51s		trunk passed
+1 💚	shadedclient	19m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s		the patch passed
+1 💚	compile	0m 28s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 28s		the patch passed
+1 💚	compile	0m 28s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 28s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 17 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	checkstyle	0m 25s		the patch passed
+1 💚	mvnsite	0m 29s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 17s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 55s		the patch passed
+1 💚	shadedclient	18m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	131m 55s		hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚	asflicense	0m 38s		The patch does not generate ASF License warnings.
		214m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3487/2/artifact/out/Dockerfile
GITHUB PR	#3487
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux eee65f779659 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `03bbd6c`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3487/2/testReport/
Max. process+thread count	1340 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3487/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

dongjoon-hyun · 2021-09-27T04:41:00Z

It's surprising because CI complains at the last commit due to blank lines at a renaming PR.
The original file seems to have some wrong style. Let me fix it to make CI happy.

hadoop-yetus · 2021-09-27T08:29:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 57s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 4s		trunk passed
+1 💚	compile	0m 40s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 36s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 39s		trunk passed
+1 💚	mvnsite	0m 43s		trunk passed
+1 💚	javadoc	0m 31s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 59s		trunk passed
+1 💚	shadedclient	25m 24s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 31s		the patch passed
+1 💚	compile	0m 30s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 30s		the patch passed
+1 💚	compile	0m 27s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 25s		the patch passed
+1 💚	mvnsite	0m 29s		the patch passed
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 53s		the patch passed
+1 💚	shadedclient	18m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	129m 9s		hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		225m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3487/3/artifact/out/Dockerfile
GITHUB PR	#3487
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 0ea9d0769d3b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4dbd0dd`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3487/3/testReport/
Max. process+thread count	1337 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3487/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

dongjoon-hyun · 2021-09-28T16:14:15Z

Gentle ping, @sunchao .

sunchao

LGTM, thanks @dongjoon-hyun

dongjoon-hyun · 2021-09-28T16:21:47Z

Thank you, @sunchao !

MAPREDUCE-7363. Rename JobClientUnitTest to TestJobClients

03bbd6c

dongjoon-hyun force-pushed the MAPREDUCE-7363 branch from 405ecd3 to 03bbd6c Compare September 26, 2021 23:52

dongjoon-hyun changed the title ~~MAPREDUCE-7363. Rename JobClientUnitTest to TestJobClient~~ MAPREDUCE-7363. Rename JobClientUnitTest to TestJobClients Sep 26, 2021

dongjoon-hyun commented Sep 27, 2021

View reviewed changes

remove blanks

4dbd0dd

sunchao approved these changes Sep 28, 2021

View reviewed changes

sunchao merged commit f5148ca into apache:trunk Sep 28, 2021

dongjoon-hyun deleted the MAPREDUCE-7363 branch September 28, 2021 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MAPREDUCE-7363. Rename JobClientUnitTest to TestJobClients #3487

MAPREDUCE-7363. Rename JobClientUnitTest to TestJobClients #3487

dongjoon-hyun commented Sep 26, 2021 •

edited

dongjoon-hyun Sep 27, 2021

dongjoon-hyun commented Sep 27, 2021

hadoop-yetus commented Sep 27, 2021

hadoop-yetus commented Sep 27, 2021

dongjoon-hyun commented Sep 27, 2021

hadoop-yetus commented Sep 27, 2021

dongjoon-hyun commented Sep 28, 2021

sunchao left a comment

dongjoon-hyun commented Sep 28, 2021

MAPREDUCE-7363. Rename JobClientUnitTest to TestJobClients #3487

MAPREDUCE-7363. Rename JobClientUnitTest to TestJobClients #3487

Conversation

dongjoon-hyun commented Sep 26, 2021 • edited

Description of PR

How was this patch tested?

For code changes:

dongjoon-hyun Sep 27, 2021

Choose a reason for hiding this comment

dongjoon-hyun commented Sep 27, 2021

hadoop-yetus commented Sep 27, 2021

hadoop-yetus commented Sep 27, 2021

dongjoon-hyun commented Sep 27, 2021

hadoop-yetus commented Sep 27, 2021

dongjoon-hyun commented Sep 28, 2021

sunchao left a comment

Choose a reason for hiding this comment

dongjoon-hyun commented Sep 28, 2021

dongjoon-hyun commented Sep 26, 2021 •

edited