New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-17951 AccessPoint verifyBucketExistsV2 always returns false #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out there was a small issue with the previous implementation that always returned `false` for `verifyBucketExistsV2`. The more "clearer" way to check is for an error message when there's a 403. If that error message is present then the AP doesn't exist (the only case when a 403 is returned for an AP), otherwise 404 means definite NO.
@steveloughran small bug fix related to Access Point PR that went in last week. |
💔 -1 overall
This message was automatically generated. |
steveloughran
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
bogthe
added a commit
to bogthe/hadoop
that referenced
this pull request
Feb 2, 2022
…he#3516) Follow-on to HADOOP-17198. Support S3 Access Points Contributed by Bogdan Stolojan
bogthe
added a commit
to bogthe/hadoop
that referenced
this pull request
Feb 2, 2022
…he#3516) Follow-on to HADOOP-17198. Support S3 Access Points Contributed by Bogdan Stolojan
steveloughran
pushed a commit
to steveloughran/hadoop
that referenced
this pull request
Feb 3, 2022
…he#3516) Follow-on to HADOOP-17198. Support S3 Access Points Contributed by Bogdan Stolojan
asfgit
pushed a commit
that referenced
this pull request
Feb 4, 2022
Follow-on to HADOOP-17198. Support S3 Access Points Contributed by Bogdan Stolojan Change-Id: I0932476c64e1967eb0cb3e0f00060fac5d2bae72
kevincong
pushed a commit
to kevincong/hadoop
that referenced
this pull request
May 18, 2022
…he#3516) Follow-on to HADOOP-17198. Support S3 Access Points Contributed by Bogdan Stolojan
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…he#3516) Follow-on to HADOOP-17198. Support S3 Access Points Contributed by Bogdan Stolojan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Turns out there was a small issue with the previous implementation that
always returned
false
forverifyBucketExistsV2
. The more "clearer"way to check is for an error message when there's a 403. If that error
message is present then the AP doesn't exist (the only case when a 403
is returned for an AP), otherwise 404 means definite no.
How was this patch tested?
Ran
mvn -Dparallel-tests -DtestsThreadCount=32 clean verify
oneu-west-1
with access points enabled (i.e. bucket pointing to AP ARN).For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?