HADOOP-17959. Replace Guava VisibleForTesting by Hadoop's own annotation in hadoop-cloud-storage-project and hadoop-mapreduce-project modules

[virajjasani]

No description provided.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	22m 58s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 1s		trunk passed
+1 💚	compile	23m 4s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	19m 42s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	3m 58s		trunk passed
+1 💚	mvnsite	8m 15s		trunk passed
+1 💚	javadoc	6m 44s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	6m 15s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	13m 25s		trunk passed
+1 💚	shadedclient	22m 10s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 38s		the patch passed
+1 💚	compile	22m 24s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	22m 24s		the patch passed
+1 💚	compile	19m 44s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	19m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 58s		the patch passed
+1 💚	mvnsite	8m 14s		the patch passed
+1 💚	xml	0m 5s		The patch has no ill-formed XML file.
+1 💚	javadoc	6m 38s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	6m 13s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	15m 32s		the patch passed
+1 💚	shadedclient	22m 30s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	157m 56s		hadoop-mapreduce-client in the patch passed.
+1 💚	unit	5m 52s		hadoop-mapreduce-client-core in the patch passed.
+1 💚	unit	1m 14s		hadoop-mapreduce-client-common in the patch passed.
+1 💚	unit	0m 46s		hadoop-mapreduce-client-shuffle in the patch passed.
+1 💚	unit	8m 29s		hadoop-mapreduce-client-app in the patch passed.
+1 💚	unit	5m 16s		hadoop-mapreduce-client-hs in the patch passed.
+1 💚	unit	126m 49s		hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚	unit	0m 43s		hadoop-mapreduce-client-uploader in the patch passed.
+1 💚	unit	0m 55s		hadoop-mapreduce-examples in the patch passed.
+1 💚	unit	0m 35s		hadoop-cos in the patch passed.
+1 💚	unit	0m 38s		hadoop-huaweicloud in the patch passed.
+1 💚	asflicense	0m 54s		The patch does not generate ASF License warnings.
		578m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3537/1/artifact/out/Dockerfile
GITHUB PR	#3537
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname	Linux e59ba515a586 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 1bc5d06
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3537/1/testReport/
Max. process+thread count	1217 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-cloud-storage-project/hadoop-cos hadoop-cloud-storage-project/hadoop-huaweicloud U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3537/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[amahussein]

+1
LGTM

[virajjasani]

Thanks for the reviews @amahussein @tasanuma.
@tasanuma could you please take a look at this one as well? Thanks

[tasanuma]

Thanks, @virajjasani and @amahussein!