YARN-8057 Inadequate information for handling catch clauses #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqjack
reviewed
Apr 21, 2018
| @@ -124,11 +124,11 @@ protected synchronized void cleanupRunningContainers() { | |||
| } catch (YarnException e) { | |||
| LOG.error("Failed to stop Container " + | |||
| startedContainer.getContainerId() + | |||
| "when stopping NMClientImpl"); | |||
| "when stopping NMClientImpl", e); | |||
There was a problem hiding this comment.
what’s the e use for in log?
There was a problem hiding this comment.
If there's no "e", the log here will only show the message "Failed to stop Container ### when stopping NMClientImpl". People will only know there's something wrong here, but will not know what's wrong here. (YarnException? IOException?)
If add an "e" here, the exception type and position where this exception happens will also be generated to the log, so that people will know what's wrong here.
554599622
approved these changes
Apr 26, 2018
|
Hey Iq you have been in my phone a lot and who ever you been on here with is hacking my phone so tell me what an WHY u messing with my phone |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
I do nothing for your phone, however I will also receive the apple id is binding by other person now . |
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…stateful operators. Verified with a test standalone job. Will add integration test for this as a part of fixing and reenabling standalone integration tests. Author: Shanthoosh Venkataraman <svenkataraman@linkedin.com> Reviewers: Boris Shkolnik <boryas@apache.org> Closes apache#362 from shanthoosh/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the problem:
https://issues.apache.org/jira/browse/YARN-8057
I added stack traces information to those two logging statements, so that the full exception information can be generated to the logs.