Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-16328. Correct disk balancer desc #3669

Merged
merged 7 commits into from Nov 18, 2021
Merged

HDFS-16328. Correct disk balancer desc #3669

merged 7 commits into from Nov 18, 2021

Conversation

GuoPhilipse
Copy link
Member

dfs.disk.balancer.enabled is enabled by default after HDFS-13153, we can improve the doc to avoid confusion

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 1s trunk passed
+1 💚 mvnsite 1m 27s trunk passed
+1 💚 shadedclient 58m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 18s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 19s the patch passed
+1 💚 shadedclient 23m 3s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
85m 56s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3669/1/artifact/out/Dockerfile
GITHUB PR #3669
Optional Tests dupname asflicense mvnsite codespell markdownlint
uname Linux eb77a241d59a 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 7218d0d
Max. process+thread count 524 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3669/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka
aajisaka approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch.

@GuoPhilipse
Copy link
Member Author

Thanks @aajisaka for your review:)

@aajisaka aajisaka changed the title HDFS-16328.Correct disk balancer desc HDFS-16328. Correct disk balancer desc Nov 18, 2021
@aajisaka aajisaka merged commit 0c1eb01 into apache:trunk Nov 18, 2021
aajisaka pushed a commit that referenced this pull request Nov 18, 2021
@GuoPhilipse @aajisaka
HDFS-16328. Correct disk balancer desc (#3669)
8166bcc 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit 0c1eb01)
aajisaka pushed a commit that referenced this pull request Nov 18, 2021
@GuoPhilipse @aajisaka
HDFS-16328. Correct disk balancer desc (#3669)
583a410 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit 0c1eb01)
@aajisaka
Copy link
Member

Merged. Thank you @GuoPhilipse

@GuoPhilipse
Copy link
Member Author

@aajisaka Thanks for your review and merging :)

@GuoPhilipse GuoPhilipse deleted the correctdoc branch November 25, 2021 11:58
sunchao pushed a commit that referenced this pull request Jan 4, 2022
@GuoPhilipse @sunchao
HDFS-16328. Correct disk balancer desc (#3669)
1e7a46b 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit 0c1eb01)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@GuoPhilipse
HDFS-16328. Correct disk balancer desc (apache#3669)
e40abb4 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aajisaka aajisaka aajisaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@GuoPhilipse @hadoop-yetus @aajisaka