-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18068. upgrade AWS SDK to 1.12.132 #3864
HADOOP-18068. upgrade AWS SDK to 1.12.132 #3864
Conversation
yetus seems to have blocked; well rebase and resubmit. |
6868238
to
ef8d505
Compare
dependenciesdependencies look good; nothing accidentally referred to.
size is now 264 MB, up from 226. that is huge, but it allows us to dodge all classpath problems we used to get about version incompatibilities of things like json parsing, http client etc. Test run with
|
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
ef8d505
to
09d4d7b
Compare
💔 -1 overall
This message was automatically generated. |
i can't get the reports, but must consider i don't see it -but my test setup does include ARN bindings...maybe that is a factor. will explore |
09d4d7b
to
fa14e37
Compare
💔 -1 overall
This message was automatically generated. |
regressions in test. unsure why I`m not seeing this
|
I believe the test is failing because the hostnames returned as endpoints have been updated. What to do?
I'd like to go with the first option because it does mean we can track these changes and be aware of them. We could try doing a DNS look up as Ultimate validation, but that would move it from being a unit test to an integration test.
Side issue: I don't understand why I didn't see this problem myself. I did the integration test runs and they should run or the unit tests as well. Will investigate. |
I am not seeing this locally at all. Which makes me suspect that there is some network IO going on here. Except: I just turn the Wi-Fi off re-run the tests and all was good. Which implies no DNS/rDNS. I've relaxed the tests so they only check part of the FQDN. |
Change-Id: I64886976b680b4918216fc7755b0b1c8d13f1242
fa14e37
to
050c8ec
Compare
Change-Id: I2ac1dd994dab3a7fe5266137a691c4d24cd4f11c
050c8ec
to
88862c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 pending Jenkins. Thank you @steveloughran
thanks; will merge asap |
With this update, the versions of key shaded dependencies are jackson 2.12.3 httpclient 4.5.13 This backport patch does not include the TestArn changes needed for the test to work with this version of the SDK; it is only to be applied to branches without HADOOP-17198. "Support S3 Access Points". If that patch is backported later, that test suite MUST be updated to the latest version. Contributed by Steve Loughran Change-Id: I8d2b71781ee8472b16469531f9cd0de32dd3356f
With this update, the versions of key shaded dependencies are jackson 2.12.3 httpclient 4.5.13 This backport patch does not include the TestArn changes needed for the test to work with this version of the SDK; it is only to be applied to branches without HADOOP-17198. "Support S3 Access Points". If that patch is backported later, that test suite MUST be updated to the latest version. Contributed by Steve Loughran Change-Id: I8d2b71781ee8472b16469531f9cd0de32dd3356f
With this update, the versions of key shaded dependencies are jackson 2.12.3 httpclient 4.5.13 Contributed by Steve Loughran Change-Id: Id9ed677352d54e8ea71b9729b6a4bfedc6142825
With this update, the versions of key shaded dependencies are jackson 2.12.3 httpclient 4.5.13 Contributed by Steve Loughran Change-Id: Id9ed677352d54e8ea71b9729b6a4bfedc6142825
With this update, the versions of key shaded dependencies are jackson 2.12.3 httpclient 4.5.13 Contributed by Steve Loughran
With this update, the versions of key shaded dependencies are jackson 2.12.3 httpclient 4.5.13 This backport patch does not include the TestArn changes needed for the test to work with this version of the SDK; it is only to be applied to branches without HADOOP-17198. "Support S3 Access Points". If that patch is backported later, that test suite MUST be updated to the latest version. Contributed by Steve Loughran Change-Id: I8d2b71781ee8472b16469531f9cd0de32dd3356f
Description of PR
move to latest AWS SDK
How was this patch tested?
itests without s3guard
full manual qualification as covered in testing doc
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?