HADOOP-13294. Test hadoop fs shell against s3a #4006
+663
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
dannycjones
approved these changes
Feb 21, 2022
dannycjones
suggested changes
Feb 21, 2022
Comment on lines
45
to
47
| /** | ||
| * Test of hadoop fs shell against S3A | ||
| */ |
There was a problem hiding this comment.
This adds a new checkstyle violation, can you push a fix?
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFsShell.java:45:/**: First sentence should end with a period. [JavadocStyle]
There was a problem hiding this comment.
Sure, I will fix it.
Comment on lines
+141
to
+142
| @Test | ||
| public void testFsShellFileOperations() throws IOException { |
There was a problem hiding this comment.
This method is too long, and raises a checkstyle violation.
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFsShell.java:141: @Test:3: Method length is 155 lines (max allowed is 150). [MethodLength]
Can we break it down? Maybe move the stream concatenation (cat, head, tail) to another method?
There was a problem hiding this comment.
Good suggestion, I will break them to another method.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
monthonk
force-pushed
the
s3/HADOOP-13294-hadoop-fs-test
branch
from
baedcb0
to
a8668b9
Compare
|
💔 -1 overall
This message was automatically generated. |
monthonk
force-pushed
the
s3/HADOOP-13294-hadoop-fs-test
branch
from
a8668b9
to
9ca8e5f
Compare
|
💔 -1 overall
This message was automatically generated. |
monthonk
force-pushed
the
s3/HADOOP-13294-hadoop-fs-test
branch
from
9ca8e5f
to
cc2cb89
Compare
|
🎊 +1 overall
This message was automatically generated. |
dannycjones
reviewed
Apr 13, 2022
There was a problem hiding this comment.
LGTM - one blocker on the root delete support.
I think this was already discussed in the HADOOP-13294...
I will update my PR for the new option and make a change to s3a files only.
So we will make it so only S3A opts-out of supporting root delete, and all other filesystems assume it is enabled by default? Sounds good!
monthonk
force-pushed
the
s3/HADOOP-13294-hadoop-fs-test
branch
from
cc2cb89
to
ede9377
Compare
|
💔 -1 overall
This message was automatically generated. |
…te root directory
… to delete root directory" This reverts commit 91a4e23313d5d9f8bcc7559cb337856cbd8f0ad6.
This reverts commit 9ca8e5fcdb9d8f4dda0281d4908e9e165ef96ca8.
monthonk
force-pushed
the
s3/HADOOP-13294-hadoop-fs-test
branch
from
ede9377
to
df6285a
Compare
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
There's no tests of hadoop -fs commands against S3a. With some tests we can see problems when using these commands with S3a (HADOOP-13294).
From the command list in FileSystemShell, I added tests for each of them, verify expected output from stdout, stderr and return code. Some tests might be a bit long because I'm trying to group the commands and run them together so it won't take too long.
Changes
How was this patch tested?
Tested in
eu-west-1withmvn -Dparallel-tests -DtestsThreadCount=16 clean verifyFor code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?