Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-11076. Upgrade jQuery version in Yarn UI2. #4046

Merged
merged 1 commit into from Mar 3, 2022

Conversation

tomicooler
Copy link
Contributor

Notes

  1. bower-shrinkwrap.json is outdated

I updated the parts in the bower-shrinkwrap.json manually as described in the README.md.

I had to add the following to the .bowerrc

"resolvers": [
    "bower-shrinkwrap-resolver"
  ]

Unfortunately the other packages are outdated in that json, so the build fail.

  1. jquery-ui is updated to 1.12.1 (the same version is in the hadoop-common repo), the 1.13.1 version is not available in that jquery-ui shims repo

  2. bootstrap 3.3.6 depended on older jQuery so it had to be updated

How was this patch tested?

I did a short smoke test on the UI2.

Change-Id: I3cb1677741df5a1978e83029443d4a2d5d7e3d7f
Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @tomicooler.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 32m 30s trunk passed
+1 💚 shadedclient 52m 1s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 15s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 19m 12s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
74m 5s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4046/1/artifact/out/Dockerfile
GITHUB PR #4046
Optional Tests dupname asflicense shadedclient codespell
uname Linux 063b16ccc64e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c4513a7
Max. process+thread count 585 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4046/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@iwasakims iwasakims merged commit 22fe79c into apache:trunk Mar 3, 2022
@iwasakims
Copy link
Member

I got no issue on branch-3.3 on my local testing.

iwasakims pushed a commit that referenced this pull request Mar 3, 2022
Change-Id: I3cb1677741df5a1978e83029443d4a2d5d7e3d7f
(cherry picked from commit 22fe79c)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Change-Id: I3cb1677741df5a1978e83029443d4a2d5d7e3d7f
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
)

NOTE: ember had to be upgraded to 2.8.0 to fix the build.
      The upstream uses 2.8.0 too: YARN-10858

# Conflicts:
#	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/bower-shrinkwrap.json

Change-Id: I3cb1677741df5a1978e83029443d4a2d5d7e3d7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants