HADOOP-18172: Change scope of InodeTree and its member methods to make them accessible from outside package. #4144

xinglin · 2022-04-06T18:32:43Z

Description of PR

backport of HADOOP-18172 for branch-2.10

How was this patch tested?

mvn install -DskipTests

hadoop-yetus · 2022-04-06T20:21:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	11m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ branch-2.10 Compile Tests _
+1 💚	mvninstall	17m 25s		branch-2.10 passed
+1 💚	compile	14m 12s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	compile	11m 18s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	checkstyle	0m 40s		branch-2.10 passed
+1 💚	mvnsite	1m 17s		branch-2.10 passed
+1 💚	javadoc	1m 15s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	0m 57s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
-1 ❌	spotbugs	2m 23s	/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html	hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 45s		the patch passed
+1 💚	compile	13m 19s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javac	13m 19s		the patch passed
+1 💚	compile	11m 16s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	javac	11m 16s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 35s		the patch passed
+1 💚	mvnsite	1m 13s		the patch passed
+1 💚	javadoc	1m 11s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	0m 57s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	spotbugs	2m 11s		the patch passed
			_ Other Tests _
-1 ❌	unit	10m 33s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		107m 54s

Reason	Tests
Failed junit tests	hadoop.fs.sftp.TestSFTPFileSystem
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.TestCompressorDecompressor

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/1/artifact/out/Dockerfile
GITHUB PR	#4144
JIRA Issue	HADOOP-18172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 7ca82a1b867f 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-2.10 / 0db60da461f9132df1a5e33c1bf330766846119b
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Multi-JDK versions	/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/1/testReport/
Max. process+thread count	1761 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/1/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

mccormickt12 · 2022-04-18T19:11:36Z

@xinglin can you add a comment to why checks are failing.

xinglin · 2022-04-18T19:20:29Z

@xinglin can you add a comment to why checks are failing.

the spotbugs/unit test failures for FTP/compresors have already been there for a while. No new test failures from this patch.

hadoop-yetus · 2022-04-20T02:01:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	8m 6s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ branch-2.10 Compile Tests _
+1 💚	mvninstall	17m 53s		branch-2.10 passed
+1 💚	compile	13m 17s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	compile	11m 31s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	checkstyle	0m 42s		branch-2.10 passed
+1 💚	mvnsite	1m 19s		branch-2.10 passed
+1 💚	javadoc	1m 24s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	1m 6s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
-1 ❌	spotbugs	2m 33s	/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html	hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 47s		the patch passed
+1 💚	compile	12m 32s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javac	12m 32s		the patch passed
+1 💚	compile	11m 36s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	javac	11m 36s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 38s		the patch passed
+1 💚	mvnsite	1m 16s		the patch passed
+1 💚	javadoc	1m 19s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	1m 4s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	spotbugs	2m 20s		the patch passed
			_ Other Tests _
-1 ❌	unit	9m 37s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	0m 49s		The patch does not generate ASF License warnings.
		104m 48s

Reason	Tests
Failed junit tests	hadoop.fs.sftp.TestSFTPFileSystem
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.TestCompressorDecompressor

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/2/artifact/out/Dockerfile
GITHUB PR	#4144
JIRA Issue	HADOOP-18172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux ad83aeff0fd1 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-2.10 / 98d3adadeeffdb2ae36836b447332b7dca83e1b7
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Multi-JDK versions	/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/2/testReport/
Max. process+thread count	1379 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/2/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-04-20T02:02:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ branch-2.10 Compile Tests _
+1 💚	mvninstall	17m 48s		branch-2.10 passed
+1 💚	compile	13m 39s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	compile	11m 36s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	checkstyle	0m 42s		branch-2.10 passed
+1 💚	mvnsite	1m 23s		branch-2.10 passed
+1 💚	javadoc	1m 22s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	1m 0s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
-1 ❌	spotbugs	2m 28s	/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html	hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 46s		the patch passed
+1 💚	compile	12m 35s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javac	12m 35s		the patch passed
+1 💚	compile	11m 34s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	javac	11m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 36s		the patch passed
+1 💚	mvnsite	1m 24s		the patch passed
+1 💚	javadoc	1m 17s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	1m 0s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	spotbugs	2m 17s		the patch passed
			_ Other Tests _
-1 ❌	unit	9m 28s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	0m 52s		The patch does not generate ASF License warnings.
		97m 24s

Reason	Tests
Failed junit tests	hadoop.fs.sftp.TestSFTPFileSystem
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.TestCompressorDecompressor

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/3/artifact/out/Dockerfile
GITHUB PR	#4144
JIRA Issue	HADOOP-18172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux ea3f48a45c53 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-2.10 / 98d3adadeeffdb2ae36836b447332b7dca83e1b7
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Multi-JDK versions	/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/3/testReport/
Max. process+thread count	1390 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/3/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

xinglin · 2022-04-20T06:05:57Z

Same unit test failures, due to failures in SFTP/compression related stuffs. these failures are already there. not related with this patch.

xinglin · 2022-04-20T18:06:23Z

force-pushed with a cherry-pick from the commit from trunk.

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java

hadoop-yetus · 2022-04-20T19:49:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ branch-2.10 Compile Tests _
+1 💚	mvninstall	17m 41s		branch-2.10 passed
+1 💚	compile	14m 21s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	compile	11m 31s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	checkstyle	0m 57s		branch-2.10 passed
+1 💚	mvnsite	1m 37s		branch-2.10 passed
+1 💚	javadoc	1m 36s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	1m 16s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
-1 ❌	spotbugs	2m 42s	/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html	hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 50s		the patch passed
+1 💚	compile	13m 19s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javac	13m 19s		the patch passed
+1 💚	compile	11m 30s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	javac	11m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 53s		the patch passed
+1 💚	mvnsite	1m 32s		the patch passed
+1 💚	javadoc	1m 38s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	1m 23s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	spotbugs	2m 46s		the patch passed
			_ Other Tests _
-1 ❌	unit	11m 11s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	1m 19s		The patch does not generate ASF License warnings.
		105m 26s

Reason	Tests
Failed junit tests	hadoop.io.compress.TestCompressorDecompressor
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.fs.sftp.TestSFTPFileSystem

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/4/artifact/out/Dockerfile
GITHUB PR	#4144
JIRA Issue	HADOOP-18172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 8b4cf0bcff82 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-2.10 / b7b1f6d89472ba9eebc0727c863be1eeeff716b0
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Multi-JDK versions	/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/4/testReport/
Max. process+thread count	1512 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/4/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajith

+1 on the changes. Will commit after yetus runs.

hadoop-yetus · 2022-04-20T23:00:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ branch-2.10 Compile Tests _
+1 💚	mvninstall	17m 45s		branch-2.10 passed
+1 💚	compile	14m 1s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	compile	11m 28s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	checkstyle	1m 9s		branch-2.10 passed
+1 💚	mvnsite	1m 43s		branch-2.10 passed
+1 💚	javadoc	1m 46s		branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	1m 27s		branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
-1 ❌	spotbugs	2m 52s	/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html	hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 55s		the patch passed
+1 💚	compile	13m 25s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javac	13m 25s		the patch passed
+1 💚	compile	11m 38s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	javac	11m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 6s		the patch passed
+1 💚	mvnsite	1m 42s		the patch passed
+1 💚	javadoc	1m 36s		the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚	javadoc	1m 28s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
+1 💚	spotbugs	2m 48s		the patch passed
			_ Other Tests _
-1 ❌	unit	9m 43s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	1m 5s		The patch does not generate ASF License warnings.
		105m 2s

Reason	Tests
Failed junit tests	hadoop.fs.sftp.TestSFTPFileSystem
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.util.TestBasicDiskValidator
	hadoop.io.compress.TestCompressorDecompressor

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/5/artifact/out/Dockerfile
GITHUB PR	#4144
JIRA Issue	HADOOP-18172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux da3a85423e71 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-2.10 / `a3f7683`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Multi-JDK versions	/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/5/testReport/
Max. process+thread count	1389 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/5/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

virajith · 2022-04-20T23:25:03Z

Failures in the yetus run are not related. Committing this.

mccormickt12 approved these changes Apr 18, 2022

View reviewed changes

Xing Lin added 2 commits April 19, 2022 17:01

HADOOP-18172: backport of HADOOP-18172 for branch-2.10

05b657e

Made a few more functions public in InodeTree

e682196

xinglin force-pushed the HADOOP-18172-2.10 branch from 0db60da to e682196 Compare April 20, 2022 00:15

xinglin force-pushed the HADOOP-18172-2.10 branch from 98d3ada to b7b1f6d Compare April 20, 2022 18:03

xinglin changed the title ~~HADOOP-18172: backport of HADOOP-18172 for branch-2.10~~ HADOOP-18172: Change scope of InodeTree and its member methods to make them accessible from outside package. Apr 20, 2022

virajith reviewed Apr 20, 2022

View reviewed changes

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java Outdated Show resolved Hide resolved

Removed Abhishek's change of scope.

a3f7683

xinglin force-pushed the HADOOP-18172-2.10 branch from b7b1f6d to a3f7683 Compare April 20, 2022 21:14

virajith approved these changes Apr 20, 2022

View reviewed changes

virajith merged commit 96ee487 into apache:branch-2.10 Apr 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-18172: Change scope of InodeTree and its member methods to make them accessible from outside package. #4144

HADOOP-18172: Change scope of InodeTree and its member methods to make them accessible from outside package. #4144

xinglin commented Apr 6, 2022

hadoop-yetus commented Apr 6, 2022

mccormickt12 commented Apr 18, 2022

xinglin commented Apr 18, 2022 •

edited

Loading

hadoop-yetus commented Apr 20, 2022

hadoop-yetus commented Apr 20, 2022

xinglin commented Apr 20, 2022

xinglin commented Apr 20, 2022

hadoop-yetus commented Apr 20, 2022

virajith left a comment

hadoop-yetus commented Apr 20, 2022

virajith commented Apr 20, 2022

HADOOP-18172: Change scope of InodeTree and its member methods to make them accessible from outside package. #4144

HADOOP-18172: Change scope of InodeTree and its member methods to make them accessible from outside package. #4144

Conversation

xinglin commented Apr 6, 2022

Description of PR

How was this patch tested?

hadoop-yetus commented Apr 6, 2022

mccormickt12 commented Apr 18, 2022

xinglin commented Apr 18, 2022 • edited Loading

hadoop-yetus commented Apr 20, 2022

hadoop-yetus commented Apr 20, 2022

xinglin commented Apr 20, 2022

xinglin commented Apr 20, 2022

hadoop-yetus commented Apr 20, 2022

virajith left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Apr 20, 2022

virajith commented Apr 20, 2022

xinglin commented Apr 18, 2022 •

edited

Loading