Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17551. Upgrade maven-site-plugin to 3.11.0 #4196

Merged
merged 2 commits into from Apr 21, 2022

Conversation

ashutoshcipher
Copy link
Contributor

Description of PR

Upgrade maven-site-plugin to 3.11.0

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending Jenkins

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 41m 4s trunk passed
+1 💚 compile 24m 57s trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 compile 21m 9s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 mvnsite 28m 15s trunk passed
+1 💚 javadoc 8m 23s trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 8m 5s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 154m 14s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 24m 17s the patch passed
+1 💚 compile 24m 15s the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javac 24m 15s the patch passed
+1 💚 compile 21m 28s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 21m 28s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-1 ❌ mvnsite 6m 24s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 8m 43s the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 8m 21s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 41m 57s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 1052m 2s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 2m 6s The patch does not generate ASF License warnings.
1329m 40s
Reason Tests
Failed junit tests hadoop.hdfs.server.mover.TestMover
hadoop.hdfs.TestReplaceDatanodeFailureReplication
hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
hadoop.hdfs.server.namenode.ha.TestObserverNode
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4196/1/artifact/out/Dockerfile
GITHUB PR #4196
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname Linux d17f9d593314 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / de2e265
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4196/1/testReport/
Max. process+thread count 3143 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4196/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn site is failing: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4196/1/artifact/out/patch-mvnsite-root.txt

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.11.0:site (default-site) on project hadoop-project: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.11.0:site failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-site-plugin:3.11.0:site: java.lang.AbstractMethodError: org.apache.maven.doxia.module.markdown.MarkdownParser.parse(Ljava/io/Reader;Lorg/apache/maven/doxia/sink/Sink;Ljava/lang/String;)V

I think the error is caused by the doxia upgrades such as https://issues.apache.org/jira/browse/MSITE-878. Would you remove the hard-coded doxia version in pom.xml?

hadoop/pom.xml

Lines 316 to 320 in de2e265

<dependency>
<groupId>org.apache.maven.doxia</groupId>
<artifactId>doxia-module-markdown</artifactId>
<version>1.8</version>
</dependency>

I removed the above lines and mvn site succeeded on my local.

@ashutoshcipher
Copy link
Contributor Author

mvn site is failing: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4196/1/artifact/out/patch-mvnsite-root.txt

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.11.0:site (default-site) on project hadoop-project: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.11.0:site failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-site-plugin:3.11.0:site: java.lang.AbstractMethodError: org.apache.maven.doxia.module.markdown.MarkdownParser.parse(Ljava/io/Reader;Lorg/apache/maven/doxia/sink/Sink;Ljava/lang/String;)V

I think the error is caused by the doxia upgrades such as https://issues.apache.org/jira/browse/MSITE-878. Would you remove the hard-coded doxia version in pom.xml?

hadoop/pom.xml

Lines 316 to 320 in de2e265

<dependency>
<groupId>org.apache.maven.doxia</groupId>
<artifactId>doxia-module-markdown</artifactId>
<version>1.8</version>
</dependency>

I removed the above lines and mvn site succeeded on my local.

@aajisaka - I will do that.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 57s trunk passed
+1 💚 compile 24m 55s trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 compile 21m 34s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 mvnsite 26m 37s trunk passed
+1 💚 javadoc 8m 42s trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 8m 24s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 156m 22s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 24m 40s the patch passed
+1 💚 compile 24m 18s the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javac 24m 18s the patch passed
+1 💚 compile 21m 36s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 21m 36s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 19m 38s the patch passed
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 javadoc 8m 22s the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 8m 22s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 41m 12s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 485m 46s /patch-unit-root.txt root in the patch failed.
+0 🆗 asflicense 1m 7s ASF License check generated no output?
778m 14s
Reason Tests
Failed CTEST tests test_libhdfs_threaded_hdfspp_test_shim_static
test_hdfspp_mini_dfs_smoke_hdfspp_test_shim_static
libhdfs_mini_stress_valgrind_hdfspp_test_static
memcheck_libhdfs_mini_stress_valgrind_hdfspp_test_static
test_libhdfs_mini_stress_hdfspp_test_shim_static
test_hdfs_ext_hdfspp_test_shim_static
x_platform_utils_test
x_platform_syscall_test
hdfs_tool_tests
Failed junit tests hadoop.hdfs.TestClientProtocolForPipelineRecovery
hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4196/2/artifact/out/Dockerfile
GITHUB PR #4196
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname Linux e643c8fb6b07 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c84dcd4
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
CTEST https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4196/2/artifact/out/patch-root-ctest.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4196/2/testReport/
Max. process+thread count 1937 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4196/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ashutoshcipher

@aajisaka aajisaka merged commit 56cfd60 into apache:trunk Apr 21, 2022
aajisaka pushed a commit that referenced this pull request Apr 21, 2022
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit 56cfd60)
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants