HADOOP-18249. Fix getUri() in HttpRequest has been deprecated. #4335

slfan1989 · 2022-05-20T05:27:09Z

Description of PR

JIRA: HADOOP-18249. Fix getUri() in HttpRequest has been deprecated.

When reading the code, I found that the method used has been deprecated due to the upgrade of the netty component. The main methods are as follows:

io.netty.handler.codec.http#HttpRequest

@Deprecated
HttpMethod getMethod();
Deprecated. Use method() instead.

@Deprecated
String getUri()
Deprecated. Use uri() instead.

io.netty.handler.codec.http#DefaultHttpResponse

@Deprecated
public HttpResponseStatus getStatus() {
        return this.status();
}
Deprecated. Use status()  instead.

WebHdfsHandler.java req.getUri() replace uri(), req.getMethod() replace method() HostRestrictingAuthorizationFilterHandler.java req.getUri() replace uri() TestHostRestrictingAuthorizationFilterHandler.java remove throws Exception, channelResponse.getStatus() replace status().

hadoop-yetus · 2022-05-20T11:20:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 59s		trunk passed
+1 💚	compile	1m 27s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 19s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 28s		trunk passed
+1 💚	javadoc	1m 6s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 28s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 20s		trunk passed
+1 💚	shadedclient	22m 9s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 15s		the patch passed
+1 💚	compile	1m 20s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 20s		hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 459 unchanged - 7 fixed = 459 total (was 466)
+1 💚	compile	1m 8s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 8s		hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 0 new + 443 unchanged - 7 fixed = 443 total (was 450)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 50s		the patch passed
+1 💚	mvnsite	1m 19s		the patch passed
+1 💚	javadoc	0m 50s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 22s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 11s		the patch passed
+1 💚	shadedclient	21m 37s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	249m 48s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 51s		The patch does not generate ASF License warnings.
		352m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/1/artifact/out/Dockerfile
GITHUB PR	#4335
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 628cdd3c5b0c 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9dccda6`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/1/testReport/
Max. process+thread count	2955 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hemanthboyina

thanks for the PR @slfan1989 , there were few more places where httprequest getUri() is used, can you modify them as well ?

slfan1989 · 2022-05-20T22:21:39Z

thanks for the PR @slfan1989 , there were few more places where httprequest getUri() is used, can you modify them as well ?

Thanks @hemanthboyina , I'll try to fix the other locations.

hadoop-yetus · 2022-05-23T12:51:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	37m 10s		trunk passed
+1 💚	compile	1m 30s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 23s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 34s		trunk passed
+1 💚	javadoc	1m 8s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 27s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 31s		trunk passed
+1 💚	shadedclient	22m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 18s		the patch passed
+1 💚	compile	1m 17s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 17s		hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 942 unchanged - 15 fixed = 942 total (was 957)
+1 💚	compile	1m 11s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 11s		hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 0 new + 921 unchanged - 15 fixed = 921 total (was 936)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 51s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 29 unchanged - 2 fixed = 30 total (was 31)
+1 💚	mvnsite	1m 16s		the patch passed
+1 💚	javadoc	0m 50s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 20s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 7s		the patch passed
+1 💚	shadedclient	21m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	248m 16s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 51s		The patch does not generate ASF License warnings.
		351m 26s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/2/artifact/out/Dockerfile
GITHUB PR	#4335
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 542e1a9e3d5b 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `deeb9c8`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/2/testReport/
Max. process+thread count	3455 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hemanthboyina

+1
will wait for build result

hadoop-yetus · 2022-05-23T19:22:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 1s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	69m 17s		trunk passed
+1 💚	compile	1m 27s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 18s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 26s		trunk passed
+1 💚	javadoc	1m 9s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 29s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 25s		trunk passed
+1 💚	shadedclient	22m 11s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 14s		the patch passed
+1 💚	compile	1m 18s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 18s		hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 942 unchanged - 15 fixed = 942 total (was 957)
+1 💚	compile	1m 10s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 10s		hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 0 new + 921 unchanged - 15 fixed = 921 total (was 936)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 51s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 29 unchanged - 2 fixed = 29 total (was 31)
+1 💚	mvnsite	1m 18s		the patch passed
+1 💚	javadoc	0m 51s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 20s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 7s		the patch passed
+1 💚	shadedclient	21m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	247m 58s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 49s		The patch does not generate ASF License warnings.
		382m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/3/artifact/out/Dockerfile
GITHUB PR	#4335
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 48519d5b0afd 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e042521`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/3/testReport/
Max. process+thread count	3866 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2022-05-24T14:59:26Z

@hemanthboyina please help me to review the code again, thank you very much!

hemanthboyina

+1

slfan1989 · 2022-05-24T21:15:05Z

@hemanthboyina Thank you very much for your help reviewing the code!

…e#4335) * HADOOP-18249. Fix getUri() in HttpRequest has been deprecated. WebHdfsHandler.java req.getUri() replace uri(), req.getMethod() replace method() HostRestrictingAuthorizationFilterHandler.java req.getUri() replace uri() TestHostRestrictingAuthorizationFilterHandler.java remove throws Exception, channelResponse.getStatus() replace status(). * HADOOP-18249. Fix getUri() in HttpRequest has been deprecated. * HADOOP-18249. Fix Some CheckStyle. Co-authored-by: slfan1989 <louj1988@@>

hemanthboyina reviewed May 20, 2022

View reviewed changes

HADOOP-18249. Fix getUri() in HttpRequest has been deprecated.

deeb9c8

slfan1989 requested a review from hemanthboyina May 23, 2022 08:06

HADOOP-18249. Fix Some CheckStyle.

e042521

hemanthboyina reviewed May 23, 2022

View reviewed changes

slfan1989 requested a review from hemanthboyina May 23, 2022 23:29

hemanthboyina approved these changes May 24, 2022

View reviewed changes

hemanthboyina merged commit f469b0e into apache:trunk May 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-18249. Fix getUri() in HttpRequest has been deprecated. #4335

HADOOP-18249. Fix getUri() in HttpRequest has been deprecated. #4335

slfan1989 commented May 20, 2022 •

edited

hadoop-yetus commented May 20, 2022

hemanthboyina left a comment

slfan1989 commented May 20, 2022

hadoop-yetus commented May 23, 2022

hemanthboyina left a comment

hadoop-yetus commented May 23, 2022

slfan1989 commented May 24, 2022 •

edited

hemanthboyina left a comment

slfan1989 commented May 24, 2022

HADOOP-18249. Fix getUri() in HttpRequest has been deprecated. #4335

HADOOP-18249. Fix getUri() in HttpRequest has been deprecated. #4335

Conversation

slfan1989 commented May 20, 2022 • edited

Description of PR

hadoop-yetus commented May 20, 2022

hemanthboyina left a comment

Choose a reason for hiding this comment

slfan1989 commented May 20, 2022

hadoop-yetus commented May 23, 2022

hemanthboyina left a comment

Choose a reason for hiding this comment

hadoop-yetus commented May 23, 2022

slfan1989 commented May 24, 2022 • edited

hemanthboyina left a comment

Choose a reason for hiding this comment

slfan1989 commented May 24, 2022

slfan1989 commented May 20, 2022 •

edited

slfan1989 commented May 24, 2022 •

edited