New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18284. Remove Unnecessary semicolon ';' #4422
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@ayushtkn please help me to review this pr, thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dropped a minor comment,
+1 once addressed
String rootDir = GenericTestUtils.getTestDir().getAbsolutePath();; | ||
private String rootDir = GenericTestUtils.getTestDir().getAbsolutePath();; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add private
here as part of this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it.
boolean spillInProgress;; | ||
private boolean spillInProgress; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add private
here as part of this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion, I will fix it.
Hi,@ayushtkn When doing this pr, I found that the test report has the following errors: Failed junit tests These two errors are both introduced by HDFS-16563, PR:#4241, Because HDFS-16563 modifies the token expiration prompt, the is expired keyword fails in the assertion. TestJHSSecurity I submitted a PR to fix, JIRA:MAPREDUCE-7387. PR:#4428 Thank you again! |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@slfan1989 can you rebase and retrigger the build once. give a check to the checkstyle warnings if they are induced by this patch |
Thank you for your help to review the code, I will do the rebase operation and fix checkstyle. |
🎊 +1 overall
This message was automatically generated. |
Hi, @ayushtkn, Thank you very much for your help reviewing the code, I read the test report about the checkstyle issue. 1st
2nd
These two places should not need to increase the private modifier. Please help me review the code again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
Checkstyle warnings are false alarms, aren't induced by this patch
Hi, @ayushtkn Can you help me merge this pr into trunk branch?Thank you very much! |
…uted by fanshilun.
JIRA:HADOOP-18284. Remove Unnecessary semicolon ';'
while reading the code, I found a very tiny optimization point, part of the code contains 2 semicolons at the end, I will fix it. Because this change is simple, I fixed it in One JIRA.
The code looks like this: