Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAPREDUCE-7390. Remove WhiteBox in mapreduce module. #4462

Merged
merged 31 commits into from Nov 14, 2022
Merged

MAPREDUCE-7390. Remove WhiteBox in mapreduce module. #4462

merged 31 commits into from Nov 14, 2022

Conversation

slfan1989
Copy link
Contributor

JIRA: MAPREDUCE-7390 Remove WhiteBox in mapreduce module.

@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@slfan1989
Copy link
Contributor Author

@jojochuang please help to review the code, thank you very much!

@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@slfan1989
Copy link
Contributor Author

@steveloughran @aajisaka Please help to review the code, I hope that Whitebox can be completely removed from the mapreduce module.

@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@steveloughran
Copy link
Contributor

afraid i'm taking a break from all non critical PR review; keeping my typing to a minimum. sorry

@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@slfan1989
Copy link
Contributor Author

@aajisaka Can you help review the code again? Thank you very much!

@hadoop-yetus

This comment was marked as outdated.

Sign in to view
aajisaka
aajisaka requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protected doesn't mean package-private. Would you remove protected?

@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 41m 59s trunk passed
+1 💚 compile 0m 53s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 45s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 0m 48s trunk passed
+1 💚 mvnsite 0m 54s trunk passed
+1 💚 javadoc 0m 41s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 31s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 42s trunk passed
+1 💚 shadedclient 23m 56s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 38s the patch passed
+1 💚 compile 0m 41s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 41s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 100 unchanged - 1 fixed = 100 total (was 101)
+1 💚 compile 0m 36s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 36s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu120.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu120.04-b07 generated 0 new + 94 unchanged - 1 fixed = 94 total (was 95)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 31s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 0 new + 97 unchanged - 4 fixed = 97 total (was 101)
+1 💚 mvnsite 0m 40s the patch passed
+1 💚 javadoc 0m 21s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 20s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 31s the patch passed
+1 💚 shadedclient 23m 52s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 7m 19s hadoop-mapreduce-client-core in the patch passed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
110m 35s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4462/29/artifact/out/Dockerfile
GITHUB PR #4462
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 4f1256035ae1 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / fa77c6f
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4462/29/testReport/
Max. process+thread count 927 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4462/29/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor Author

@aajisaka Can you help review the code again? Thank you very much!

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 24s trunk passed
+1 💚 compile 1m 0s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 49s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 1m 0s trunk passed
+1 💚 mvnsite 0m 56s trunk passed
+1 💚 javadoc 0m 53s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 35s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 44s trunk passed
+1 💚 shadedclient 21m 0s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 38s the patch passed
+1 💚 compile 0m 43s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 43s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 100 unchanged - 1 fixed = 100 total (was 101)
+1 💚 compile 0m 40s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 40s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu120.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu120.04-b07 generated 0 new + 94 unchanged - 1 fixed = 94 total (was 95)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 31s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 0 new + 97 unchanged - 4 fixed = 97 total (was 101)
+1 💚 mvnsite 0m 42s the patch passed
+1 💚 javadoc 0m 22s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 21s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 27s the patch passed
+1 💚 shadedclient 20m 51s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 7m 24s hadoop-mapreduce-client-core in the patch passed.
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
102m 58s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4462/30/artifact/out/Dockerfile
GITHUB PR #4462
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 35a45545bcbe 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 72f6940
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4462/30/testReport/
Max. process+thread count 1579 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4462/30/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

aajisaka
aajisaka approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks

@aajisaka aajisaka merged commit 04b31d7 into apache:trunk Nov 14, 2022
@aajisaka
Copy link
Member

Thank you @slfan1989 for your contribution and thanks @xinglin for your review.

@slfan1989
Copy link
Contributor Author

slfan1989 commented Nov 14, 2022 •
edited

@aajisaka Thank you very much for helping to review the code! @xinglin Thanks also for your help reviewing the code!

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@slfan1989
MAPREDUCE-7390. Remove WhiteBox in mapreduce module. (apache#4462)
504a5e3 
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinglin xinglin xinglin approved these changes

@aajisaka aajisaka aajisaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@slfan1989 @hadoop-yetus @steveloughran @aajisaka @xinglin