-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18292. Fix s3 select tests when running against unsupported storage class #4489
Merged
steveloughran
merged 4 commits into
apache:trunk
from
monthonk:HADOOP-18292-fix-s3-select-tests
Oct 13, 2022
Merged
HADOOP-18292. Fix s3 select tests when running against unsupported storage class #4489
steveloughran
merged 4 commits into
apache:trunk
from
monthonk:HADOOP-18292-fix-s3-select-tests
Oct 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
ahmarsuhail
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, looks good
4 tasks
asfgit
pushed a commit
that referenced
this pull request
Oct 13, 2022
…orage class (#4489) Follow-on from HADOOP-12020. Contributed by Monthon Klongklaew
asfgit
pushed a commit
that referenced
this pull request
Oct 13, 2022
…orage class (#4489) Follow-on from HADOOP-12020. Contributed by Monthon Klongklaew
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…orage class (apache#4489) Follow-on from HADOOP-12020. Contributed by Monthon Klongklaew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-18292. when you set your fs client to work with unsupported storage classes, the s3 select tests fail.
Fix by removing storage class option before running S3 Select tests.
How was this patch tested?
Tested with a bucket in
eu-west-1
withmvn -Dparallel-tests -DtestsThreadCount=16 clean verify
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?