HADOOP-18321.Fix when to read an additional record from a BZip2 text file split #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saswata-dutta
approved these changes
Jul 1, 2022
aajisaka
reviewed
Jul 5, 2022
Comment on lines
25
to
28
| @Override | ||
| public void setUp() throws Exception { | ||
| super.setUp(); | ||
| } |
There was a problem hiding this comment.
I think the lines are not required for the checkstyle fix.
There was a problem hiding this comment.
Thanks @aajisaka - I have addressed the above comment.
|
Other than the above comment, I'm +1 for this change. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thanks @ashutoshcipher for the patch and @aajisaka for the review. |
|
My late +1. Thank you @PrabhuJoseph and @ashutoshcipher |
|
Thanks @aajisaka @PrabhuJoseph and @saswata-dutta :) |
| import static org.apache.hadoop.io.compress.bzip2.BZip2TextFileWriter.BLOCK_SIZE; | ||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| import java.io.ByteArrayInputStream; |
There was a problem hiding this comment.
bit late, but the imports are completely out of sync with the normal hadoop rules. check your ide settings.
There was a problem hiding this comment.
Thanks @steveloughran for pointing it out. I am using this for code formatting - https://github.com/apache/hadoop/blob/trunk/dev-support/code-formatter/hadoop_idea_formatter.xml
There was a problem hiding this comment.
that file puts statics at the bottom. at least it should. if it doesn't that's a bug
There was a problem hiding this comment.
@steveloughran - I will file a JIRA and fix the imports.
There was a problem hiding this comment.
@steveloughran - Created PR to sync imports - #4694
Sorry for being little late. Was busy in some other stuff. Thanks.
There was a problem hiding this comment.
no worries. if you aren't behind on lots of things then you aren't a full time software engineer....
aajisaka
pushed a commit
that referenced
this pull request
Aug 7, 2022
…file split (#4521) * HADOOP-18321.Fix when to read an additional record from a BZip2 text file split Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com> and Reviewed by Akira Ajisaka. (cherry picked from commit a432925)
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…file split (apache#4521) * HADOOP-18321.Fix when to read an additional record from a BZip2 text file split Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com> and Reviewed by Akira Ajisaka.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Fix when to read an additional record from a BZip2 text file split
JIRA - HADOOP-18321
How was this patch tested?
Added Units
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?