HDFS-15079. RBF: Namenode needs to use the actual client Id and callId when going through RBF proxy. #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d when going through RBF proxy.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Jul 5, 2022
| @@ -46,6 +46,15 @@ | |||
| public static final Logger LOG = LoggerFactory.getLogger( | |||
| RetryInvocationHandler.class); | |||
|
|
|||
| @VisibleForTesting | |||
| public static final ThreadLocal<Boolean> SET_CALL_ID_FOR_TEST = | |||
| new ThreadLocal<Boolean>() { | |||
There was a problem hiding this comment.
There's no lambda or shorter version for this?
| Path renameDst = new Path(testDir, "renameDst"); | ||
| joeFS.mkdirs(renameSrc); | ||
|
|
||
| Assert.assertEquals(HAServiceProtocol.HAServiceState.ACTIVE, |
There was a problem hiding this comment.
You can statically import these asserts and just do assertEqual()
| @@ -495,6 +498,72 @@ public static NameNodeMetrics getNameNodeMetrics() { | |||
| return metrics; | |||
| } | |||
|
|
|||
| private static String clientInfoFromContext( | |||
| return null; | ||
| } | ||
|
|
||
| private static String parseSpecialValue(String content, String key) { |
...-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
Show resolved
Hide resolved
...-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
Show resolved
Hide resolved
|
@goiri Thanks for your review and I have updated the patch, please help me review it. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri @ferhui @Hexiaoqiao @ayushtkn can you help me to review this patch? If you have any other ideas, please let me know. This is a very helpful issue for end users, so I want to push it forward. |
goiri
reviewed
Jul 13, 2022
| @@ -140,7 +140,7 @@ public long getExpirationTime() { | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| return (new UUID(this.clientIdMsb, this.clientIdLsb)).toString() + ":" | |||
| return (new UUID(this.clientIdMsb, this.clientIdLsb)) + ":" | |||
There was a problem hiding this comment.
Maybe is cleaner to have this as String.format()
goiri
approved these changes
Jul 14, 2022
|
It would be nice to get feedback from others. |
|
🎊 +1 overall
This message was automatically generated. |
ferhui
reviewed
Jul 18, 2022
...-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
Show resolved
Hide resolved
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…d when going through RBF proxy. (apache#4530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Jira: HDFS-15079
Similarly with HDFS-13248, RBF adds the actual client Id and client call Id in CallerContext and carries them to NameNode. Then nameNode try to obtain the actual client Id and client call Id to ensure CacheEntry mechanism.