HADOOP-18332: remove rs-api dependency as it conflicts with jsr311-api #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjfanning could you please create PR against branch-3.3 in parallel? I think this would be more beneficial to branch-3.3 than trunk. On HADOOP-18033, it's still being discussed if we should only consider branch-3.3 for this PR because HADOOP-15984 anyways requires javax.ws.rs-api (and hence, Jackson 2.13). |
|
@virajjasani I created #4552 for the 3.3 branch |
|
💔 -1 overall
This message was automatically generated. |
|
Closing in favour of #4544 |
3 tasks
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Jul 12, 2022
There was a problem hiding this comment.
@pjfanning guess you missed removing some changes, need to remove the excludes:
https://github.com/apache/hadoop/pull/4544/files#diff-f07b301991f3fb8edf3704aeb176293c329211e8f1283ced2d778b40db1f75beL707
and
|
@ayushtkn I had those changes ready to commit before I closed this PR - I've merged them now - we'll see how this build goes |
|
Nothing major changing so the build should stay clean. |
|
If the build comes clean, on a quick look I am +1 on this. Please give a check or let me know if someone intends to do so and needs time, I will hold this further |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
The failed tests passes locally
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.yarn.server.router.rmadmin.TestRouterRMAdminService
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.583 s - in org.apache.hadoop.yarn.server.router.rmadmin.TestRouterRMAdminService
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy
[INFO] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.428 s - in org.apache.hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0
[INFO]
Changes LGTM
|
💔 -1 overall
This message was automatically generated. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
apache#4547) This downgrades jackson from the version switched to in HADOOP-18033 (2.13.0), to Jackson 2.12.7. This removes the dependency on javax.ws.rs-api, so avoiding runtime problems with applications using jersey-core v1 and/or jsr311-api. The 2.12.7 release still contains the fix for CVE-2020-36518. Contributed by PJ Fanning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Relates to https://issues.apache.org/jira/browse/HADOOP-18332 - rs-api jar seems to cause conflicts with jsr311-api jar (latter is needed by jersey-core 1.19)
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?