HDFS-16660. Improve Code With Lambda in IPCLoggerChannel class #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goiri
reviewed
Jul 13, 2022
| return getProxy().isFormatted(journalId, nameServiceId); | ||
| } | ||
| }); | ||
| return singleThreadExecutor.submit( |
| return ret; | ||
| } | ||
| return singleThreadExecutor.submit(() -> { | ||
| GetJournalStateResponseProto ret = |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jul 14, 2022
| getProxy().journal(createReqInfo(), | ||
| segmentTxId, firstTxnId, numTxns, data); | ||
| } catch (IOException e) { | ||
| QuorumJournalManager.LOG.warn( |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jul 15, 2022
...oject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
Outdated
Show resolved
Hide resolved
| long now = System.nanoTime(); | ||
| long rpcTime = TimeUnit.MICROSECONDS.convert( | ||
| now - rpcSendTimeNanos, TimeUnit.NANOSECONDS); | ||
| long endToEndTime = TimeUnit.MICROSECONDS.convert( |
| return null; | ||
| throw e; | ||
| } finally { | ||
| long now = System.nanoTime(); |
|
@goiri Can help me reivew it and push it forward? After this, I will create a PR try to improve codes with Lambda in the whole hadoop-hdfs module. |
goiri
approved these changes
Jul 26, 2022
|
@goiri Hi, master, can you help me merge it into the trunk? I will move to improve codes with Lambda in the whole hadoop-hdfs module. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Improve Code With Lambda in IPCLoggerChannel class, make it more readable.