HDFS-16681. Do not pass GCC flags for MSVC in libhdfspp #4615

GauthamBanasandra · 2022-07-23T18:36:57Z

Description of PR

The tests in HDFS native client uses the -Wno-missing-field-initializers flag to ignore warnings about uninitialized members -

hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/CMakeLists.txt

Lines 27 to 28 in 8f83d9f

    
           set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-missing-field-initializers") 
        
           set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-missing-field-initializers")

This leads to the following error on Visual C++.

[exec] "E:\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\ALL_BUILD.vcxproj" (default target) (1) ->
[exec] "E:\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\x-platform\x_platform_dirent_test_obj.vcxproj" (default target) (24) ->
[exec]   cl : command line error D8021: invalid numeric argument '/Wno-missing-field-initializers' [E:\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\x-platform\x_platform_dirent_test_obj.vcxproj]

Thus, we need to pass this flag only when the compiler isn't Visual C++.

How was this patch tested?

Tested by building locally on my Windows 10 PC.
Hadoop Jenkins CI validation.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

* This PR ensures that the GCC flag -Wno-missing-field-initializers isn't passed for MSVC.

hadoop-yetus · 2022-07-23T23:13:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	47m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	42m 10s		trunk passed
+1 💚	compile	4m 2s		trunk passed
+1 💚	mvnsite	0m 43s		trunk passed
+1 💚	shadedclient	69m 9s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 20s		the patch passed
+1 💚	compile	3m 42s		the patch passed
+1 💚	cc	3m 42s		the patch passed
+1 💚	javac	3m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	shadedclient	22m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	128m 2s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 46s		The patch does not generate ASF License warnings.
		274m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/artifact/out/Dockerfile
GITHUB PR	#4615
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname	Linux 5284c572cd2a 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `af899ed`
Default Java	Red Hat, Inc.-1.8.0_332-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/testReport/
Max. process+thread count	601 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/console
versions	git=2.9.5 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-07-24T03:01:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	26m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	25m 56s		trunk passed
+1 💚	compile	4m 15s		trunk passed
+1 💚	mvnsite	0m 59s		trunk passed
+1 💚	shadedclient	53m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	3m 47s		the patch passed
+1 💚	cc	3m 47s		the patch passed
+1 💚	javac	3m 47s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 29s		the patch passed
+1 💚	shadedclient	22m 39s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	116m 50s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 49s		The patch does not generate ASF License warnings.
		228m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/artifact/out/Dockerfile
GITHUB PR	#4615
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname	Linux 18d6b5aeed64 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `af899ed`
Default Java	Red Hat, Inc.-1.8.0_312-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/testReport/
Max. process+thread count	531 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/console
versions	git=2.27.0 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-07-24T07:08:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	26m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	31m 6s		trunk passed
+1 💚	compile	3m 45s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	shadedclient	66m 20s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 21s		the patch passed
+1 💚	compile	3m 28s		the patch passed
+1 💚	cc	3m 28s		the patch passed
+1 💚	javac	3m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	shadedclient	32m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	113m 25s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		246m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/artifact/out/Dockerfile
GITHUB PR	#4615
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname	Linux 49aaa0ac343d 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `af899ed`
Default Java	Debian-11.0.16+8-post-Debian-1deb10u1
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/testReport/
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/console
versions	git=2.20.1 maven=3.6.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-07-24T10:40:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 2s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	24m 40s		trunk passed
+1 💚	compile	4m 38s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	4m 38s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	0m 41s		trunk passed
+1 💚	shadedclient	58m 23s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 20s		the patch passed
+1 💚	compile	4m 5s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	cc	4m 5s		the patch passed
+1 💚	javac	4m 5s		the patch passed
+1 💚	compile	4m 10s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	cc	4m 10s		the patch passed
+1 💚	javac	4m 10s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	shadedclient	22m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	117m 59s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		212m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/artifact/out/Dockerfile
GITHUB PR	#4615
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets
uname	Linux 669a83d65d05 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `af899ed`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/testReport/
Max. process+thread count	615 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4615/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

* This PR ensures that the GCC flag -Wno-missing-field-initializers isn't passed for MSVC.

HDFS-16681. Do not pass GCC flags for MSVC in libhdfspp

af899ed

* This PR ensures that the GCC flag -Wno-missing-field-initializers isn't passed for MSVC.

GauthamBanasandra added the HDFS label Jul 23, 2022

GauthamBanasandra self-assigned this Jul 23, 2022

GauthamBanasandra requested a review from goiri July 23, 2022 18:58

GauthamBanasandra marked this pull request as ready for review July 24, 2022 12:21

goiri approved these changes Jul 24, 2022

View reviewed changes

GauthamBanasandra merged commit 6ba2c53 into apache:trunk Jul 25, 2022

GauthamBanasandra deleted the gcc-flags branch July 25, 2022 17:25

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HDFS-16681. Do not pass GCC flags for MSVC in libhdfspp (apache#4615)

9986368

* This PR ensures that the GCC flag -Wno-missing-field-initializers isn't passed for MSVC.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-16681. Do not pass GCC flags for MSVC in libhdfspp #4615

HDFS-16681. Do not pass GCC flags for MSVC in libhdfspp #4615

GauthamBanasandra commented Jul 23, 2022

hadoop-yetus commented Jul 23, 2022

hadoop-yetus commented Jul 24, 2022

hadoop-yetus commented Jul 24, 2022

hadoop-yetus commented Jul 24, 2022

	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-missing-field-initializers")
	set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-missing-field-initializers")

HDFS-16681. Do not pass GCC flags for MSVC in libhdfspp #4615

HDFS-16681. Do not pass GCC flags for MSVC in libhdfspp #4615

Conversation

GauthamBanasandra commented Jul 23, 2022

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented Jul 23, 2022

hadoop-yetus commented Jul 24, 2022

hadoop-yetus commented Jul 24, 2022

hadoop-yetus commented Jul 24, 2022