-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18372. ILoadTestS3ABulkDeleteThrottling failing. #4642
HADOOP-18372. ILoadTestS3ABulkDeleteThrottling failing. #4642
Conversation
do we know what could cause this to fail now? As in previously, the config must have been set correctly for the tests to have passed. currently config was being set before the FS was created here (I think fs is created somewhere in the setup) which should be ok? so a little confused as to why this is happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. some minor tweaks needed
...adoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java
Outdated
Show resolved
Hide resolved
...adoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
LGTM. which endpoint did you test against? |
🎊 +1 overall
This message was automatically generated. |
|
thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
tested on branch-3.3; all good so merging there too |
Contributed by Ahmar Suhail
Description of PR
This test was failing because:
unaudited operation executing a request outside an audit span
. It was passing when I disabled auditing.Have moved up setting config values to
createScaleConfiguration
, added auditing.How was this patch tested?
Since it's only updating the test, ran
ILoadTestS3ABulkDeleteThrottling
oneu-west-1
, all tests are passing.