HDFS-16710. Remove redundant throw exceptions in org.apache.hadoop.hdfs.server.namenode package #4670

ZanderXu · 2022-08-01T15:54:56Z

Description of PR

When I read some class about HDFS NameNode, I found there are many redundant throw exception in org.apahce.hadoop.hdfs.server.namenode package, such as:

public synchronized void transitionToObserver(StateChangeRequestInfo req)
    throws ServiceFailedException, AccessControlException, IOException {
  checkNNStartup();
  nn.checkHaStateChange(req);
  nn.transitionToObserver();
}

Because ServiceFailedException and AccessControlException is subClass of IOException, so I feel that ServiceFailedException and AccessControlException are redundant, so we can remove it to make code clearer, such as:

public synchronized void transitionToObserver(StateChangeRequestInfo req)
    throws IOException {
  checkNNStartup();
  nn.checkHaStateChange(req);
  nn.transitionToObserver();
}

goiri · 2022-08-01T17:42:33Z

...adoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CheckpointFaultInjector.java

@@ -36,9 +36,9 @@ public static void set(CheckpointFaultInjector instance) {
    CheckpointFaultInjector.instance = instance;
  }
  public void beforeGetImageSetsHeaders() throws IOException {}
-  public void afterSecondaryCallsRollEditLog() throws IOException {}


What is the source for so many wrong definitions?

slfan1989 · 2022-08-01T19:47:12Z

LGTM.
Moudle level processing, I agree with this very much!

hadoop-yetus · 2022-08-01T23:42:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 1s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 53s		trunk passed
+1 💚	compile	1m 50s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 35s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 20s		trunk passed
+1 💚	mvnsite	1m 50s		trunk passed
+1 💚	javadoc	1m 29s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 49s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 11s		trunk passed
+1 💚	shadedclient	26m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 33s		the patch passed
+1 💚	compile	1m 30s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 30s		the patch passed
+1 💚	compile	1m 20s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 3s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 360 unchanged - 3 fixed = 367 total (was 363)
+1 💚	mvnsite	1m 29s		the patch passed
+1 💚	javadoc	0m 58s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 34s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 35s		the patch passed
+1 💚	shadedclient	25m 23s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	345m 45s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 0s		The patch does not generate ASF License warnings.
		466m 5s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestCheckpoint

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/1/artifact/out/Dockerfile
GITHUB PR	#4670
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 52ff54f33b77 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / eaf260d02094328ce7b8a65a3e829558d250d7f5
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/1/testReport/
Max. process+thread count	2062 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2022-08-02T00:41:28Z

@ZanderXu We need to pay attention to checkstyle, and then see if the junit test problem is related to this change. Thank you.

ZanderXu · 2022-08-02T02:33:58Z

We need to pay attention to checkstyle, and then see if the junit test problem is related to this change. Thank you.
@slfan1989 Copy, sir, I will fix them later.

ZanderXu · 2022-08-02T13:20:14Z

@slfan1989 Sir, I have updated the patch to fix the checkstyle, please help me review it again. Thanks

hadoop-yetus · 2022-08-02T21:48:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	17m 17s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 57s		trunk passed
+1 💚	compile	1m 41s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 42s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 32s		trunk passed
+1 💚	mvnsite	1m 54s		trunk passed
+1 💚	javadoc	1m 33s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	2m 1s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 20s		trunk passed
+1 💚	shadedclient	28m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 24s		the patch passed
+1 💚	compile	1m 29s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 29s		the patch passed
+1 💚	compile	1m 20s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 2s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 358 unchanged - 3 fixed = 358 total (was 361)
+1 💚	mvnsite	1m 28s		the patch passed
+1 💚	javadoc	0m 57s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 32s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 34s		the patch passed
+1 💚	shadedclient	26m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	369m 20s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 6s		The patch does not generate ASF License warnings.
		507m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/2/artifact/out/Dockerfile
GITHUB PR	#4670
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux d5070b366d2e 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 18b567926afbd0217b0f59e5556aede5e6624036
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/2/testReport/
Max. process+thread count	1975 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2022-08-03T01:44:36Z

LGTM.

ZanderXu · 2022-08-11T12:56:20Z

@goiri Hi, Master, can help me merge this pr into trunk? Thank you very much.

ZanderXu · 2022-09-07T14:48:20Z

@goiri @slfan1989 Masters, I have rebased this PR on the latest trunk. Sorry to ping you to help me merge this to trunk. I think it is helpful for the simplicity of the code. If you agree it, please help me to merge it into the trunk. Else let me close this PR. Thanks again.

hadoop-yetus · 2022-09-07T16:24:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 22s		trunk passed
+1 💚	compile	1m 38s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 32s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 17s		trunk passed
+1 💚	mvnsite	1m 37s		trunk passed
+1 💚	javadoc	1m 15s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 42s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 43s		trunk passed
+1 💚	shadedclient	26m 14s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
-1 ❌	mvninstall	0m 52s	/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
-1 ❌	compile	0m 54s	/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.
-1 ❌	javac	0m 54s	/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.
-1 ❌	compile	0m 51s	/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt	hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.
-1 ❌	javac	0m 50s	/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt	hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 0s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 358 unchanged - 3 fixed = 358 total (was 361)
-1 ❌	mvnsite	0m 52s	/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
+1 💚	javadoc	0m 56s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 30s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
-1 ❌	spotbugs	0m 51s	/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
-1 ❌	shadedclient	14m 37s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	0m 55s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch failed.
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		99m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/3/artifact/out/Dockerfile
GITHUB PR	#4670
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ac204ff63a45 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 109eef49bdd26b49ebe4be9cd08c27e230c410de
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/3/testReport/
Max. process+thread count	532 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

…fs.server.namenode package

hadoop-yetus · 2022-09-08T08:52:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	42m 16s		trunk passed
+1 💚	compile	1m 36s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 32s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 19s		trunk passed
+1 💚	mvnsite	1m 39s		trunk passed
+1 💚	javadoc	1m 16s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 44s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 46s		trunk passed
+1 💚	shadedclient	26m 11s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 23s		the patch passed
+1 💚	compile	1m 27s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 27s		the patch passed
+1 💚	compile	1m 21s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 0s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 358 unchanged - 3 fixed = 358 total (was 361)
+1 💚	mvnsite	1m 27s		the patch passed
+1 💚	javadoc	0m 56s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 34s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 32s		the patch passed
+1 💚	shadedclient	26m 7s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	337m 26s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 57s		The patch does not generate ASF License warnings.
		456m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/4/artifact/out/Dockerfile
GITHUB PR	#4670
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 31bb70f3aa98 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `16fa1c1`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/4/testReport/
Max. process+thread count	2004 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4670/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

goiri changed the title ~~HDFS-16710. Remove redundant throw exceptions in org.apahce.hadoop.hdfs.server.namenode package~~ HDFS-16710. Remove redundant throw exceptions in org.apache.hadoop.hdfs.server.namenode package Aug 1, 2022

goiri approved these changes Aug 1, 2022

View reviewed changes

ZanderXu force-pushed the HDFS-16710 branch from eaf260d to 18b5679 Compare August 2, 2022 13:19

ZanderXu force-pushed the HDFS-16710 branch from 18b5679 to 109eef4 Compare September 7, 2022 14:43

HDFS-16710. Remove redundant throw exceptions in org.apahce.hadoop.hd…

16fa1c1

…fs.server.namenode package

ZanderXu force-pushed the HDFS-16710 branch from 109eef4 to 16fa1c1 Compare September 8, 2022 01:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-16710. Remove redundant throw exceptions in org.apache.hadoop.hdfs.server.namenode package #4670

HDFS-16710. Remove redundant throw exceptions in org.apache.hadoop.hdfs.server.namenode package #4670

ZanderXu commented Aug 1, 2022

goiri Aug 1, 2022

slfan1989 commented Aug 1, 2022 •

edited

hadoop-yetus commented Aug 1, 2022

slfan1989 commented Aug 2, 2022

ZanderXu commented Aug 2, 2022

ZanderXu commented Aug 2, 2022

hadoop-yetus commented Aug 2, 2022

slfan1989 commented Aug 3, 2022

ZanderXu commented Aug 11, 2022

ZanderXu commented Sep 7, 2022

hadoop-yetus commented Sep 7, 2022

hadoop-yetus commented Sep 8, 2022

HDFS-16710. Remove redundant throw exceptions in org.apache.hadoop.hdfs.server.namenode package #4670

Are you sure you want to change the base?

HDFS-16710. Remove redundant throw exceptions in org.apache.hadoop.hdfs.server.namenode package #4670

Conversation

ZanderXu commented Aug 1, 2022

Description of PR

goiri Aug 1, 2022

Choose a reason for hiding this comment

slfan1989 commented Aug 1, 2022 • edited

hadoop-yetus commented Aug 1, 2022

slfan1989 commented Aug 2, 2022

ZanderXu commented Aug 2, 2022

ZanderXu commented Aug 2, 2022

hadoop-yetus commented Aug 2, 2022

slfan1989 commented Aug 3, 2022

ZanderXu commented Aug 11, 2022

ZanderXu commented Sep 7, 2022

hadoop-yetus commented Sep 7, 2022

hadoop-yetus commented Sep 8, 2022

slfan1989 commented Aug 1, 2022 •

edited