YARN-6972. Adding RM ClusterId in AppInfo. #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
3 tasks
goiri
reviewed
Aug 2, 2022
| @@ -182,6 +188,16 @@ public AppInfo(ResourceManager rm, RMApp app, Boolean hasAccess, | |||
| this.finalStatus = app.getFinalApplicationStatus(); | |||
| this.clusterId = ResourceManager.getClusterTimeStamp(); | |||
| if (hasAccess) { | |||
| if(rm != null && rm.getConfig() != null) { | |||
| try { | |||
| subClusterId = new SubClusterIdInfo( | |||
There was a problem hiding this comment.
One line.
Too many parentheses.
We should extract a little.
There was a problem hiding this comment.
Your suggestion is correct, I am going to modify the code!
| try { | ||
| subClusterId = new SubClusterIdInfo( | ||
| (YarnConfiguration.getClusterId(rm.getConfig()))); | ||
| rmClusterId = |
| @@ -1825,6 +1826,8 @@ public void verifyAppInfo(JSONObject info, RMApp app, boolean hasResourceReqs) | |||
| } | |||
| assertEquals("incorrect number of elements", expectedNumberOfElements, | |||
| info.length()); | |||
| assertEquals("rmClusterId is incorrect", "subCluster1", | |||
| @@ -182,6 +188,16 @@ public AppInfo(ResourceManager rm, RMApp app, Boolean hasAccess, | |||
| this.finalStatus = app.getFinalApplicationStatus(); | |||
| this.clusterId = ResourceManager.getClusterTimeStamp(); | |||
| if (hasAccess) { | |||
| if(rm != null && rm.getConfig() != null) { | |||
| @@ -82,6 +87,7 @@ public class AppInfo { | |||
| protected String trackingUrl; | |||
| protected String diagnostics; | |||
| protected long clusterId; | |||
| private String rmClusterId; | |||
There was a problem hiding this comment.
Kind of weird that everything else is protected.
goiri
approved these changes
Aug 2, 2022
goiri
approved these changes
Aug 2, 2022
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri I saw the checkstyle problem, but I personally feel that it can be ignored, and I prefer to change the variable to protected. |
|
@slfan1989 I'm fine ignoring that checkstyle. |
|
@goiri Thank you very much for your help reviewing the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-6972. Adding RM ClusterId in AppInfo.
The content completed by this pr is relatively simple. I refer to the code of YARN-6973 and the Patch of YARN-6972.
YARN-6972 does the following:
When queries appInfo, it will try to read rmClusterId from the current YARN configuration file to identify this application which Cluster does it belong to.