HADOOP-18028. Rebase S3A Prefetch feature branch to trunk #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the the initial merge of the HADOOP-18028 S3A performance input stream. This patch on its own is incomplete and must be accompanied by all other commits with HADOOP-18028 in their git commit message. Consult the JIRA for that list Contributed by Bhalchandra Pandit.
…3A prefetching stream (apache#4115) Contributed by PJ Fanning.
Contributed by Ahmar Suhail
…ache#4212) Contributed by Monthon Klongklaew
apache#4386) * adds in new test for prefetching input stream * creates streamStats before opening stream * updates numBlocks calculation method * fixes ITestS3AOpenCost.testOpenFileLongerLength * drains stream async * fixes failing unit test Contributed by Ahmar Suhail
Contributed by Ahmar Suhail <ahmarsu@amazon.co.uk>
This adds iOStatisticsConnection to the S3PrefetchingInputStream class, with new statistic names in StreamStatistics. This stream is not (yet) IOStatisticsContext aware. Contributed by Ahmar Suhail
Fixes the build and a test failure (ITestS3ARequesterPays) which was always there if you tested without prefetching enabled. Change-Id: I4503c64856cfeb453b558808065b38455e1fce23
|
done in the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the commit chain of feature-HADOOP-18028-s3a-prefetch rebased to trunk and with a fixup at the end.
I intend to apply this chain to the feature branch with a goal of a squash and merge of the branch into trunk ASAP, with all final work done on trunk
How was this patch tested?
s3 london, params
-Dparallel-tests -DtestsThreadCount=8 -Dscaleall new failures reported
ITestS3SelectLandsat timeout after 10 minutes. surfaces in trunk too.
ITestS3AFileSystemStatistic failure in prefetch feature branch
ITestS3ACannedACLs failure; not in a span.
I don't believe any are related, rather that changing the #of tests triggered latent issues surfacing from different states of the jvm before each suite, or, in the case of the landsat one, some change in the endpoint.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?